diff options
author | Frantisek Sumsal <frantisek@sumsal.cz> | 2022-09-14 22:04:15 +0200 |
---|---|---|
committer | Frantisek Sumsal <frantisek@sumsal.cz> | 2022-09-14 22:09:19 +0200 |
commit | 9fe61660bae81acfa5c387ba68c51c643b175510 (patch) | |
tree | b309069101cc2f9fb3b431568803b7013363717a /.github/codeql-queries/UninitializedVariableWithCleanup.ql | |
parent | ci: enable a couple more possibly useful CodeQL queries (diff) | |
download | systemd-9fe61660bae81acfa5c387ba68c51c643b175510.tar.xz systemd-9fe61660bae81acfa5c387ba68c51c643b175510.zip |
ci: fix a couple of typos
Diffstat (limited to '')
-rw-r--r-- | .github/codeql-queries/UninitializedVariableWithCleanup.ql | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/.github/codeql-queries/UninitializedVariableWithCleanup.ql b/.github/codeql-queries/UninitializedVariableWithCleanup.ql index 6b3b62f8bc..e514111f28 100644 --- a/.github/codeql-queries/UninitializedVariableWithCleanup.ql +++ b/.github/codeql-queries/UninitializedVariableWithCleanup.ql @@ -50,16 +50,16 @@ class UninitialisedLocalReachability extends StackVariableReachability { * fun(&x); * puts(x); * - * `useOfVarActual()` won't treat this an an uninitialized read even if the callee + * `useOfVarActual()` won't treat this as an uninitialized read even if the callee * doesn't modify the argument, however, `useOfVar()` will */ override predicate isSink(ControlFlowNode node, StackVariable v) { useOfVar(v, node) } override predicate isBarrier(ControlFlowNode node, StackVariable v) { - // only report the _first_ possibly uninitialized use + /* only report the _first_ possibly uninitialized use */ useOfVar(v, node) or ( - /* If there's an return statement somewhere between the variable declaration + /* If there's a return statement somewhere between the variable declaration * and a possible definition, don't accept is as a valid initialization. * * E.g.: @@ -71,7 +71,7 @@ class UninitialisedLocalReachability extends StackVariableReachability { * x = malloc(...); * * is not a valid initialization, since we might return from the function - * _before_ the actual iniitialization (emphasis on _might_, since we + * _before_ the actual initialization (emphasis on _might_, since we * don't know if the return statement might ever evaluate to true). */ definitionBarrier(v, node) and @@ -92,14 +92,14 @@ predicate containsInlineAssembly(Function f) { exists(AsmStmt s | s.getEnclosing * for this check to exclude them. */ VariableAccess commonException() { - // If the uninitialized use we've found is in a macro expansion, it's - // typically something like va_start(), and we don't want to complain. + /* If the uninitialized use we've found is in a macro expansion, it's + * typically something like va_start(), and we don't want to complain. */ result.getParent().isInMacroExpansion() or result.getParent() instanceof BuiltInOperation or - // Finally, exclude functions that contain assembly blocks. It's - // anyone's guess what happens in those. + /* Finally, exclude functions that contain assembly blocks. It's + * anyone's guess what happens in those. */ containsInlineAssembly(result.getEnclosingFunction()) } |