diff options
| author | Dominique Martinet <asmadeus@codewreck.org> | 2021-11-24 14:27:22 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2021-11-24 18:42:37 +0100 |
| commit | 3da361064bf550d1818c7cd800a514326058e5f2 (patch) | |
| tree | 90fa9a88e08d83f9eb0d0735c0cc850d56f45b11 | |
| parent | shell-completion: add journalctl --facility (diff) | |
| download | systemd-3da361064bf550d1818c7cd800a514326058e5f2.tar.xz systemd-3da361064bf550d1818c7cd800a514326058e5f2.zip | |
unit_is_bound_by_inactive: fix return pointer check
*ret_culprit should be set if ret_culprit has been passed a non-null value,
checking the previous *ret_culprit value does not make sense.
This would cause the culprit to not properly be assigned, leading to
pid1 crash when a unit could not be stopped.
Fixes: #21476
| -rw-r--r-- | src/core/unit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/unit.c b/src/core/unit.c index fa21b8acb2..e4f8bac442 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -2129,7 +2129,7 @@ bool unit_is_bound_by_inactive(Unit *u, Unit **ret_culprit) { continue; if (UNIT_IS_INACTIVE_OR_FAILED(unit_active_state(other))) { - if (*ret_culprit) + if (ret_culprit) *ret_culprit = other; return true; |