diff options
| author | Lennart Poettering <lennart@poettering.net> | 2024-07-19 14:40:47 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2024-07-19 18:59:01 +0200 |
| commit | e8468541727db9cea18cf29c39f46013bce1bae3 (patch) | |
| tree | ac3c1a2e528f7e876ce410c1c4b508fd1b5ffa57 | |
| parent | zsh: add varlinkctl completions (diff) | |
| download | systemd-e8468541727db9cea18cf29c39f46013bce1bae3.tar.xz systemd-e8468541727db9cea18cf29c39f46013bce1bae3.zip | |
execute: add FIXME comment
As requested by @YHNdnzj:
https://github.com/systemd/systemd/pull/33707#discussion_r1684055699
| -rw-r--r-- | src/core/exec-invoke.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/core/exec-invoke.c b/src/core/exec-invoke.c index ea85c36581..8c7e29f17a 100644 --- a/src/core/exec-invoke.c +++ b/src/core/exec-invoke.c @@ -497,6 +497,9 @@ static int setup_output( i = fixup_input(context, socket_fd, params->flags & EXEC_APPLY_TTY_STDIN); o = fixup_output(context->std_output, socket_fd); + // FIXME: we probably should spend some time here to verify that if we inherit an fd from stdin + // (possibly indirect via inheritance from stdout) it is actually opened for write! + if (fileno == STDERR_FILENO) { ExecOutput e; e = fixup_output(context->std_error, socket_fd); |