diff options
| author | Daan De Meyer <daan.j.demeyer@gmail.com> | 2024-05-30 16:24:42 +0200 |
|---|---|---|
| committer | Daan De Meyer <daan.j.demeyer@gmail.com> | 2024-05-30 19:31:32 +0200 |
| commit | ba592dc715eed67b0c939ded94b4c31bc5ba1070 (patch) | |
| tree | 7fa9be09baec776b3e3c0be6d75fab4c4b1311f4 /docs/HACKING.md | |
| parent | Merge pull request #33101 from DaanDeMeyer/revert (diff) | |
| download | systemd-ba592dc715eed67b0c939ded94b4c31bc5ba1070.tar.xz systemd-ba592dc715eed67b0c939ded94b4c31bc5ba1070.zip | |
mkosi: Replace submodules with our own thing
Unfortunately, git submodules break in all sorts of ways:
- Various github workflows (dependabot, github pages) try to do a shallow
clone of git submodules which does not work at all when the git repository
is hosted on pagure (https://pagure.io/pagure/issue/5453,
https://github.com/dependabot/dependabot-core/issues/9391).
- If the git forge hosting the git repository uses SHA256, then it breaks our
usage of it as a submodule as SHA256 repositories cannot be used as submodules
in SHA1 repositories (src.opensuse.org moved to SHA256 which broke our usage of
opensuse's systemd spec as a submodule).
- git submodules completely break usage of git worktrees.
- ...
Let's avoid all these issues by just doing our own home grown implementation of
git submodules. We lose the automatic dependabot updates this way but since dependabot
fails to run more often that not with submodules we don't really lose anything.
Diffstat (limited to 'docs/HACKING.md')
| -rw-r--r-- | docs/HACKING.md | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/docs/HACKING.md b/docs/HACKING.md index 980a45929e..51499d7f79 100644 --- a/docs/HACKING.md +++ b/docs/HACKING.md @@ -22,15 +22,6 @@ If adding a new source file, consider adding a matching test executable. For features at a higher level, tests in `src/test/` are very strongly recommended. If that is not possible, integration tests in `test/` are encouraged. -```shell -$ git config submodule.recurse true -$ git config fetch.recurseSubmodules on-demand -$ git config push.recurseSubmodules no -$ cp .git/hooks/pre-commit.sample .git/hooks/pre-commit -$ cp tools/git-submodule-update-hook.sh .git/hooks/post-rewrite -$ cp tools/git-submodule-update-hook.sh .git/hooks/post-checkout -``` - Please always test your work before submitting a PR. For many of the components of systemd testing is straightforward as you can simply compile systemd and run the relevant tool from the build directory. |