summaryrefslogtreecommitdiffstats
path: root/src/backlight
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2021-10-13 12:38:37 +0200
committerLennart Poettering <lennart@poettering.net>2021-10-14 15:57:52 +0200
commit2f82562bad423d1190912a4b209647dfac966db2 (patch)
tree766d61a085ee9674d8034351a83f64bcdf5d45bb /src/backlight
parentjournal: drop unnecessary +1 in newa() expression (diff)
downloadsystemd-2f82562bad423d1190912a4b209647dfac966db2.tar.xz
systemd-2f82562bad423d1190912a4b209647dfac966db2.zip
alloc-util: add strdupa_safe() + strndupa_safe() and use it everywhere
Let's define two helpers strdupa_safe() + strndupa_safe() which do the same as their non-safe counterparts, except that they abort if called with allocations larger than ALLOCA_MAX. This should ensure that all our alloca() based allocations are subject to this limit. afaics glibc offers three alloca() based APIs: alloca() itself, strndupa() + strdupa(). With this we have now replacements for all of them, that take the limit into account.
Diffstat (limited to 'src/backlight')
-rw-r--r--src/backlight/backlight.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c
index 6fcf584667..fd92135fc7 100644
--- a/src/backlight/backlight.c
+++ b/src/backlight/backlight.c
@@ -387,7 +387,7 @@ static int run(int argc, char *argv[]) {
if (!sysname)
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Requires a subsystem and sysname pair specifying a backlight device.");
- ss = strndupa(argv[2], sysname - argv[2]);
+ ss = strndupa_safe(argv[2], sysname - argv[2]);
sysname++;