diff options
| author | Chris Down <chris@chrisdown.name> | 2018-12-12 15:58:46 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2018-12-12 20:47:40 +0100 |
| commit | e92aaed30e0b5750e5633765f1bddd51c96678e5 (patch) | |
| tree | b568cc092a868d3a4226f529e943d3cde8e72f82 /src/coredump | |
| parent | Merge pull request #10892 from mbiebl/revert-systemctl-runtime-unmask-breakage (diff) | |
| download | systemd-e92aaed30e0b5750e5633765f1bddd51c96678e5.tar.xz systemd-e92aaed30e0b5750e5633765f1bddd51c96678e5.zip | |
tree-wide: Remove O_CLOEXEC from fdopen
fdopen doesn't accept "e", it's ignored. Let's not mislead people into
believing that it actually sets O_CLOEXEC.
From `man 3 fdopen`:
> e (since glibc 2.7):
> Open the file with the O_CLOEXEC flag. See open(2) for more information. This flag is ignored for fdopen()
As mentioned by @jlebon in #11131.
Diffstat (limited to 'src/coredump')
| -rw-r--r-- | src/coredump/coredump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c index 79d627c465..0c888b26f9 100644 --- a/src/coredump/coredump.c +++ b/src/coredump/coredump.c @@ -553,7 +553,7 @@ static int compose_open_fds(pid_t pid, char **open_fds) { if (fd < 0) continue; - fdinfo = fdopen(fd, "re"); + fdinfo = fdopen(fd, "r"); if (!fdinfo) { safe_close(fd); continue; |