diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2019-01-06 17:37:00 +0100 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2019-01-06 17:37:00 +0100 |
commit | 69bd76f2b90cd00c1596b2e2c05845a4d9596fd2 (patch) | |
tree | 57a8ca6e153c65ca39f4abf5166721c6dedf063d /src/login/pam_systemd.c | |
parent | Revert "pam_systemd: drop setting DBUS_SESSION_BUS_ADDRESS" (diff) | |
download | systemd-69bd76f2b90cd00c1596b2e2c05845a4d9596fd2.tar.xz systemd-69bd76f2b90cd00c1596b2e2c05845a4d9596fd2.zip |
pam_systemd: set $DBUS_SESSION_BUS_ADDRESS unconditionally
There's very little lost if the variable is set for a socket that isn't
connectible, but a lot lost (races, ...) if it's not set but the socket exists.
Also, drop the FIXME note, since we don't plan to revert this revert any time
soon.
Diffstat (limited to '')
-rw-r--r-- | src/login/pam_systemd.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/login/pam_systemd.c b/src/login/pam_systemd.c index cdec102cea..d466e50969 100644 --- a/src/login/pam_systemd.c +++ b/src/login/pam_systemd.c @@ -198,18 +198,6 @@ static int export_legacy_dbus_address( _cleanup_free_ char *s = NULL; int r = PAM_BUF_ERR; - /* FIXME: We *really* should move the access() check into the - * daemons that spawn dbus-daemon, instead of forcing - * DBUS_SESSION_BUS_ADDRESS= here. */ - - s = strjoin(runtime, "/bus"); - if (!s) - goto error; - - if (access(s, F_OK) < 0) - return PAM_SUCCESS; - - s = mfree(s); if (asprintf(&s, DEFAULT_USER_BUS_ADDRESS_FMT, runtime) < 0) goto error; |