diff options
| author | Franck Bui <fbui@suse.com> | 2019-06-21 13:12:41 +0200 |
|---|---|---|
| committer | Franck Bui <fbui@suse.com> | 2019-06-26 11:17:23 +0200 |
| commit | 47cf786c0a13fccd777c334bed4b1e7b02f18d42 (patch) | |
| tree | f85199d6d6d48669f3433222609cf84f67c95371 /sysctl.d | |
| parent | coredump: fix one memleak in backtrace mode (diff) | |
| download | systemd-47cf786c0a13fccd777c334bed4b1e7b02f18d42.tar.xz systemd-47cf786c0a13fccd777c334bed4b1e7b02f18d42.zip | |
coredump: rely on /proc exclusively to get the name of the crashing process
I couldn't see any reason why the kernel could provide COMM to the coredump
handler via the core_pattern command line but could not make it available in
/proc. So let's assume that this info is always available in /proc.
For "backtrace" mode (when --backtrace option is passed), I assumed that the
crashing process still exists at the time systemd-coredump is called.
Also changing the core_pattern line is an API breakage for any users of the
backtrace mode but given that systemd-coredump is installed in
/usr/lib/systemd, it's a private tool which has no internal users. At least no
one complained when the hostname was added to the core_pattern line
(f45b8015513)...
Indeed it's much easier to get it from /proc since the kernel substitutes '%e'
specifier with multiple strings if the process name contains spaces (!).
Diffstat (limited to 'sysctl.d')
| -rw-r--r-- | sysctl.d/50-coredump.conf.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sysctl.d/50-coredump.conf.in b/sysctl.d/50-coredump.conf.in index ccd5c2cc56..47bf847693 100644 --- a/sysctl.d/50-coredump.conf.in +++ b/sysctl.d/50-coredump.conf.in @@ -9,4 +9,4 @@ # and systemd-coredump(8) and core(5) for the explanation of the # setting below. -kernel.core_pattern=|@rootlibexecdir@/systemd-coredump %P %u %g %s %t %c %h %e +kernel.core_pattern=|@rootlibexecdir@/systemd-coredump %P %u %g %s %t %c %h |