summaryrefslogtreecommitdiffstats
path: root/udev_dbus.c
diff options
context:
space:
mode:
authorkay.sievers@vrfy.org <kay.sievers@vrfy.org>2004-02-27 04:37:47 +0100
committerGreg KH <gregkh@suse.de>2005-04-27 06:32:30 +0200
commitc472e3c89b9aaad90ad6398c0d2ff5dcf5a9d238 (patch)
treedf5bf5be11d19b5b29b6507055964a6d0a688a1a /udev_dbus.c
parent[PATCH] manpage update (diff)
downloadsystemd-c472e3c89b9aaad90ad6398c0d2ff5dcf5a9d238.tar.xz
systemd-c472e3c89b9aaad90ad6398c0d2ff5dcf5a9d238.zip
[PATCH] udev - safer string handling all over the place
On Tue, Feb 24, 2004 at 11:50:52PM +0100, Kay Sievers wrote: > Here is the first step towards a safer string handling. > More will follow, but for now only the easy ones :) > > Thanks to all who pointed this out. strncat() isn't a nice function. We > all should remember that the destination string is not terminated if the > given lenght is shorter than the strlen of the source string. > > And shame on the various implementers of strfieldcat() I found in the > unapplied patches on this list, it's not really better than strncpy() > and hides the real problem. Hmm, bk didn't checked in one file, maybe I edited it again as root. Nevermind, here is the more complete version.
Diffstat (limited to 'udev_dbus.c')
-rw-r--r--udev_dbus.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/udev_dbus.c b/udev_dbus.c
index da633a31a1..7b672ef363 100644
--- a/udev_dbus.c
+++ b/udev_dbus.c
@@ -80,8 +80,8 @@ void sysbus_send_create(struct udevice *dev, const char *path)
if (sysbus_connection == NULL)
return;
- strncpy(filename, udev_root, sizeof(filename));
- strncat(filename, dev->name, sizeof(filename));
+ strfieldcpy(filename, udev_root);
+ strfieldcat(filename, dev->name);
/* object, interface, member */
message = dbus_message_new_signal("/org/kernel/udev/NodeMonitor",
@@ -114,8 +114,8 @@ void sysbus_send_remove(const char* name, const char *path)
if (sysbus_connection == NULL)
return;
- strncpy(filename, udev_root, sizeof(filename));
- strncat(filename, name, sizeof(filename));
+ strfieldcpy(filename, udev_root);
+ strfieldcat(filename, name);
/* object, interface, member */
message = dbus_message_new_signal("/org/kernel/udev/NodeMonitor",