summaryrefslogtreecommitdiffstats
path: root/units/suspend.target
diff options
context:
space:
mode:
authorAlan Jenkins <alan.christopher.jenkins@gmail.com>2017-08-30 18:20:23 +0200
committerLennart Poettering <lennart@poettering.net>2017-08-30 18:20:23 +0200
commit64a36ae4b1dd23474dd7ea261381ac437b24fac2 (patch)
tree0830a9ac744f54e417c37d546984aabcaf8dbef7 /units/suspend.target
parentsulogin-shell: remove ineffective job mode option from `systemctl isolate` (#... (diff)
downloadsystemd-64a36ae4b1dd23474dd7ea261381ac437b24fac2.tar.xz
systemd-64a36ae4b1dd23474dd7ea261381ac437b24fac2.zip
units: starting suspend.target should not fail when suspend is successful (#6678)
and the same for hibernate.target and hybrid-sleep.target. Tested with both sucessful and unsuccessful suspends. The result of the start job was correct in both cases. Closes #6419 (a regression in v233 and v234). > suspend is unsual for a target, because it has to stop itself once it's > started. Otherwise you couldn't start it again, so you could only suspend > once! Currently that's implemented using BindsTo=systemd-sleep.service. > Meaning it pulls in systemd-sleep.service to do the actual suspend, and > then de-activates afterwards. But the behaviour of BindsTo was changed > recently (not without some issues during development) - maybe this bug > is caused by poettering/systemd@631b676 which I think was added in > release v233. > > sleep.target (see man systemd.special) has the same need, but it > implements it differently. It simply has StopWhenUnneeded=yes. This commit switches suspend.target etc. to the approach used by sleep.target.
Diffstat (limited to 'units/suspend.target')
-rw-r--r--units/suspend.target3
1 files changed, 2 insertions, 1 deletions
diff --git a/units/suspend.target b/units/suspend.target
index f50cb2264f..80d652755c 100644
--- a/units/suspend.target
+++ b/units/suspend.target
@@ -9,5 +9,6 @@
Description=Suspend
Documentation=man:systemd.special(7)
DefaultDependencies=no
-BindsTo=systemd-suspend.service
+Requires=systemd-suspend.service
After=systemd-suspend.service
+StopWhenUnneeded=yes