summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* hostnamed: properly reset hw model/vendor props before re-reading themLennart Poettering2022-03-241-1/+3
| | | | Follow-up for 4fc7e4f374bf4401330e90e267227267abf1dcac
* machine-info: rename VENDOR=/MODEL= → HARDWARE_VENDOR=/HARDWARE_MODEL=Lennart Poettering2022-03-243-18/+20
| | | | | | | | | | | | Let's be more precise here. Otherwise people might think this describes the software system or so. We already expose this via hostnamed as HardwareVendor/HardwareModel hence use the exact same wording. (Note that the relevant props on the dmi device are just VENDOR/MODEL, but that's OK given that DMI really is about hardware anyway, unconditionally, hence no chance of confusion there.) Follow-up for 4fc7e4f374bf4401330e90e267227267abf1dcac
* Merge pull request #22855 from keszybz/test-68-reload-reloadFrantisek Sumsal2022-03-241-30/+12
|\ | | | | TEST-68: replace daemon-reload with separate handler units
| * TEST-68: instead of calling daemon-reload, just use different cleanup unitsZbigniew Jędrzejewski-Szmek2022-03-241-10/+12
| | | | | | | | | | | | | | | | On a very slow machine, things are executed out-of-order, and something pins the previously-exited unit. Instead of fighting with this with daemon-reload, let's just use a different cleanup unit. Hopefully fixes #22755.
| * TEST-68: get rid of unnecessary descriptionsZbigniew Jędrzejewski-Szmek2022-03-241-20/+0
| | | | | | | | | | The name of the unit already says all, no need to duplicate this. And the comments can easily get out of date, as they did.
* | Merge pull request #22840 from poettering/efivars-tweaksLennart Poettering2022-03-2412-646/+688
|\ \ | | | | | | util-lib: efi variable access refactorings
| * | efi-loader: split efi-api.[ch] from efi-loader.[ch]Lennart Poettering2022-03-2410-620/+653
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some refactoring: split efi-loader.[ch] in two: isolate the calls that implement out boot loader interface spec, and those which implement access to upstream UEFI firmware features. They are quite different in nature and behaviour, and even semantically it makes to keep these two separate. At the very least because the previous name "efi-loader.[ch]" suggests all was about loader-specific APIs, but much of it is generic uefi stuff... While we are at it, I renamed a bunch of return parameters to follow our usual ret_xyz naming. But besides renaming no real code changes.
| * | efivars: define efi variable flags less weirdlyLennart Poettering2022-03-241-3/+4
| | | | | | | | | | | | | | | The flags are actually 32bit values, but aligned with zeroes befitting a 64bit value. Let's fix that.
| * | efivarfs: rename a couple of return params to ret_xyz/retLennart Poettering2022-03-242-16/+16
| | |
| * | efivars: downgrade log level in systemd_efi_options_efivarfs_if_newer()Lennart Poettering2022-03-241-1/+2
| | | | | | | | | | | | | | | The only caller logs anyway, let's avoid duplicate logging above LOG_DEBUG.
| * | efivars: no need to convert ENOENT → ENODATA twiceLennart Poettering2022-03-241-4/+2
| | | | | | | | | | | | read_efi_options_variable() already does this, don#t do it again.
| * | efivars: tweak debug log message in efi_get_secure_boot_mode()Lennart Poettering2022-03-241-1/+2
| | | | | | | | | | | | mention what we'll do as effect of the error we are seeing and eat up.
| * | efivars: cache ENOENT as no efi secure bootLennart Poettering2022-03-241-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On systems lacking EFI or the SecureBoot efi var the caching of this info didn#t work, since we'd see ENOENT when reading the var, and cache that, which we then use as reason to retry next time. Let's fix that and convert ENOENT to "secure boot", because that's what it really means. All other errors are left as is (and reason to retry). But let's add some debug logging for that case.
* | | NEWS: various tweaksLennart Poettering2022-03-241-56/+71
| | |
* | | udev: try to reload selinux label database less frequentlyYu Watanabe2022-03-241-4/+4
| | | | | | | | | | | | | | | | | | | | | Previously, `event_run()` was called repeatedly in one `event_queue_start()` invocation. Hence, the SELinux label database is reloaded many times needlessly. Other settings, e.g. udev rules or hwdata, are tried to be reloaded in the beginning of `event_queue_start()`. Let's also do so for the SELinux database.
* | | udev: assume there is no blocker when failed to check event dependenciesYu Watanabe2022-03-241-8/+5
| | | | | | | | | | | | | | | | | | | | | | | | Previously, if udevd failed to resolve event dependency, the event is ignored and libudev listeners did not receive the event. This is inconsistent with the case when a worker failed to process a event, in that case, the original uevent sent by the kernel is broadcasted to listeners.
* | | udev: only ignore ENOENT or friends which suggest the block device is not existYu Watanabe2022-03-241-2/+4
| | | | | | | | | | | | | | | | | | | | | The ENOENT, ENXIO, and ENODEV error can happen easily when a block device appears and soon removed. So, it is reasonable to ignore the error. But other errors should not occur here, and hence let's handle them as critical.
* | | errno-util: add ERRNO_IS_DEVICE_ABSENT() macroLennart Poettering2022-03-244-5/+14
| | | | | | | | | | | | Inspired by: https://github.com/systemd/systemd/pull/22717#discussion_r834254495
* | | udev: remove /run/udev/queue in on_post()Yu Watanabe2022-03-241-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the last queued event is processed, information about subsequent events may be already queued in the netlink socket of sd-device-monitor. In that case, previously we once removed /run/udev/queue and touch the file soon later, and `udevadm settle` mistakenly considered all events are processed. To mitigate such situation, this makes /run/udev/queue removed in on_post().
* | | udev: use sd_event_source_disable_unref()Yu Watanabe2022-03-243-11/+11
| | | | | | | | | | | | | | | This should not change any behavior, as the event sources are not shared. Just for safety.
* | | udev: update comment and log messageYu Watanabe2022-03-241-2/+3
|/ /
* | bpf-firewall: invert testLennart Poettering2022-03-241-10/+11
| | | | | | | | | | | | | | Following our coding style of exiting early (instead of deep nesting), let's invert the if check here. Inspired by: https://github.com/systemd/systemd/pull/21602#pullrequestreview-919960060
* | logind-user: log about the right unitDavid Tardon2022-03-241-1/+1
| |
* | journal-remote: refuse to specify --trust option when gnutls is disabledYu Watanabe2022-03-242-6/+9
| | | | | | | | | | | | and check_permission() should not be called in that case. Replaces #22847.
* | cryptsetup: fix typoAntonio Alvarez Feijoo2022-03-241-1/+1
| |
* | update TODOLennart Poettering2022-03-241-0/+2
| |
* | Merge pull request #22800 from poettering/safe-ptr-sub1Yu Watanabe2022-03-2311-57/+85
|\ \ | | | | | | Add helper macro PTR_SUB1() to deal with backwards iteration through arrays without UB
| * | dns-domain: use PTR_SUB1() macroYu Watanabe2022-03-231-11/+5
| | |
| * | test: add tests for device idYu Watanabe2022-03-231-2/+13
| | |
| * | sd-device: use path_find_last_component() to set driver subsystemYu Watanabe2022-03-231-14/+8
| | |
| * | path-util: use PTR_SUB1() macro in path_find_last_component()Yu Watanabe2022-03-231-9/+7
| | |
| * | core/namespace: inline one more iterator variableYu Watanabe2022-03-231-7/+5
| | |
| * | tree-wide: use PTR_SUB1() at two places where appropriateLennart Poettering2022-03-232-2/+2
| | |
| * | macro: add macro that simplifies going backwards through an array via pointersLennart Poettering2022-03-232-0/+39
| | | | | | | | | | | | Inspired by #22797, let's avoid some UB when iterating through arrays.
| * | various: inline some iterator variablesZbigniew Jędrzejewski-Szmek2022-03-232-12/+6
| | |
* | | network: do not enable IPv4 ACD for IPv4 link-local address if ACD is ↵Yu Watanabe2022-03-233-9/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | disabled explicitly The commit 1cf4ed142d6c1e2b9dc6a0bc74b6a83ae30b0f8e makes the IPv4 ACD enabled unconditionally for IPv4 link-local addresses even if users explicitly disable ACD. This makes the IPv4 ACD is enabled by default, but honor user setting. Fixes #22763.
* | | lgtm: disable cpp/missing-return (again)Frantisek Sumsal2022-03-231-0/+2
| |/ |/| | | | | | | | | | | It looks like the fix for https://github.com/github/codeql/issues/8409 is not yet in production (and the respective query needs to be enabled in both the main and the PR branch to get results for it, hence why it passed in #22837).
* | meson: Detect python instead of hard-coding python3Heiko Becker2022-03-231-1/+2
| | | | | | | | | | It allows to specify the desired python executable (and version) via meson's native file if there are multiple versions available.
* | Revert "lgtm: disable cpp/missing-return"Frantisek Sumsal2022-03-231-2/+0
| | | | | | | | | | | | This reverts commit 6f4bffb586dfb0ce8db4e02ccb7f076a45bca419. Should be, hopefully, fixed by https://github.com/github/codeql/issues/8409.
* | doc: two markdown markup fixesLennart Poettering2022-03-231-2/+2
| |
* | doc: add a bunch of missing <br>Lennart Poettering2022-03-231-6/+6
|/
* Merge pull request #22835 from keszybz/foreach_string-inline-iteratorYu Watanabe2022-03-2353-147/+67
|\ | | | | Inline the iterator declaration in FOREACH_STRING
| * systemctl: use the right name in error messageZbigniew Jędrzejewski-Szmek2022-03-231-1/+1
| |
| * strv: declare iterator of FOREACH_STRING() in the loopZbigniew Jędrzejewski-Szmek2022-03-2353-146/+66
| | | | | | | | | | | | | | | | | | | | | | Same idea as 03677889f0ef42cdc534bf3b31265a054b20a354. No functional change intended. The type of the iterator is generally changed to be 'const char*' instead of 'char*'. Despite the type commonly used, modifying the string was not allowed. I adjusted the naming of some short variables for clarity and reduced the scope of some variable declarations in code that was being touched anyway.
* | Merge pull request #22836 from poettering/more-build-image-docsZbigniew Jędrzejewski-Szmek2022-03-237-37/+79
|\ \ | | | | | | docs: more tweaks for the image building docs
| * | docs: extend BUILDING_IMAGES with a section about IMAGE_ID=/IMAGE_VERSION=Lennart Poettering2022-03-231-18/+58
| | | | | | | | | | | | Also, beef up links everywhere.
| * | docs: link up new image building docs a bitLennart Poettering2022-03-233-11/+13
| | |
| * | docs: make man page links in markdown Links section use teletype font, as we ↵Lennart Poettering2022-03-233-8/+8
| | | | | | | | | | | | usually do
* | | update TODOLennart Poettering2022-03-231-0/+8
|/ /
* | Merge pull request #22791 from keszybz/bootctl-invert-orderLennart Poettering2022-03-233-34/+24
|\ \ | |/ |/| Invert order of entries w/o sort-key in sd-boot menu