summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* sd-ndisc: make ndisc_send() and icmp6_send() take struct in6_addrYu Watanabe2024-04-148-23/+16
| | | | No functional change, just refactoring.
* libsystemd-network: make constant addresses type-safeYu Watanabe2024-04-149-21/+24
| | | | No functional change, just refactoring.
* dhcp6-network: constify argumentsYu Watanabe2024-04-144-20/+11
| | | | No functional change, just refactoring.
* Merge pull request #32194 from henryli001/lihl/add-defaultUseDomains-configYu Watanabe2024-04-149-1/+77
|\ | | | | network: add mechanism to configure default UseDomains= setting
| * network: add mechanism to configure default UseDomains= setting, update man ↵Henry Li2024-04-149-1/+77
| | | | | | | | page and add test
* | man: remove PrivateMounts= from list of other settings in its own descriptionOle Peder Brandtzæg2024-04-141-6/+6
| | | | | | | | | | The diff looks bigger, but that's only because it seemed fitting to reformat the paragraph now that the list is shorter.
* | Merge pull request #32257 from yuwata/tree-wide-trivial-style-fixesYu Watanabe2024-04-1312-111/+119
|\ \ | | | | | | tree-wide: trivial style and typo fixes
| * | tree-wide: insert missing space after commaYu Watanabe2024-04-127-11/+11
| | |
| * | journal: drop thousands separator in commentYu Watanabe2024-04-121-1/+1
| | |
| * | home: wrap long lineYu Watanabe2024-04-121-1/+9
| | |
| * | homectl: realign tableYu Watanabe2024-04-121-96/+96
| | |
| * | network/ndisc: fix typoYu Watanabe2024-04-121-1/+1
| | | | | | | | | | | | Follow-up for e42a74803a5a9a8acf0d630dd775736610af4600.
| * | core: fix typoYu Watanabe2024-04-121-1/+1
| | | | | | | | | | | | Follow-up for 21b366121f02aaeba5ba8c7597bba21c450172b5.
* | | vmspawn: check firmware target architectureSam Leonard2024-04-121-28/+78
|/ / | | | | | | | | Fixes issue #32026 by only finding firmwares which explicitly support the native architecture.
* | fuzz: check that resource records are serialized successfullyEvgeny Vereshchagin2024-04-121-6/+4
| | | | | | | | | | | | | | | | | | It shouldn't fail at that point. It's prompted by the "Structure needs cleaning" thing that keeps popping up in various places like https://github.com/systemd/systemd/pull/30952#discussion_r1553181309 and https://github.com/systemd/systemd/issues/31708.
* | Merge pull request #32255 from YHNdnzj/strextendfYu Watanabe2024-04-122-9/+9
|\ \ | | | | | | shared/killall: minor modernization
| * | shared/killall: minor modernizationMike Yuan2024-04-121-8/+8
| | |
| * | string-util: correct comment in strextendf_with_separatorMike Yuan2024-04-121-1/+1
| | |
* | | Merge pull request #32256 from YHNdnzj/network-close-and-replaceYu Watanabe2024-04-121-6/+4
|\ \ \ | | | | | | | | sd-dhcp-server: use close_and_replace (avoid fd leak)
| * | | sd-dhcp-server: use close_and_replace (avoid fd leak)Mike Yuan2024-04-121-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Follow-up for 11b88419ae0004547a0724aa459ddcb5d243f25c Fixes #32252
| * | | sd-dhcp-server: check dir_fd with assert_returnMike Yuan2024-04-121-3/+1
|/ / /
* | | vmspawn: add --discard-disk= to control handling of disk discard requestsSam Leonard2024-04-122-1/+21
| | | | | | | | | | | | | | | Fixes issue #32024, using --discard-disk=yes will enable handling of disk discarding requests, saving space for long running VMs as desired.
* | | test: add instructions on how to run Coverity locallyFrantisek Sumsal2024-04-121-0/+45
| | | | | | | | | | | | | | | | | | | | | This requires a Coverity license, so the usefulness of the instructions is somewhat limited, but at least I won't have to re-discover everything from scratch when I need to debug something Coverity-related again in the future.
* | | vmspawn: update parse_boolean to parse_boolean_argumentSam Leonard2024-04-121-10/+4
| | |
* | | bus-polkit: fix return value for `varlink_allow_interactive_authentication()`Antonio Alvarez Feijoo2024-04-121-2/+4
| | | | | | | | | | | | Follow-up for d04c1a1c8e7c95daa483d8d52d5fc4c25fbc67f2
* | | meson: do not fail build with newer kernel headersZbigniew Jędrzejewski-Szmek2024-04-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | systemd-255 is failing a build with the latest kernel headers… Let's downgrade this warning, because it's fine if there's a file system we don't know about and it makes thing less brittle if we don't treat this as a hard error. (I initially conditionalized this on BUILD_MODE, but I don't think we need a hard error there either. A warning will be noticed and fixed.)
* | | ndisc-option: also ignore Prefix Information option with multicast addressYu Watanabe2024-04-121-1/+3
| | | | | | | | | | | | Fixes https://github.com/systemd/systemd/pull/32215#issuecomment-2049624693
* | | Merge pull request #32240 from yuwata/network-ndisc-fix-on-link-prefixDaan De Meyer2024-04-121-58/+21
|\ \ \ | | | | | | | | network/ndisc: fixlets for on-link prefix
| * | | network/ndisc: drop onlink prefix when valid lifetime is zeroYu Watanabe2024-04-111-3/+17
| | | | | | | | | | | | | | | | Replaces 155d7a2c049cf866a0bfde8de371f09dfb3b6f29.
| * | | network/ndisc: do nothing for existing routes if on-link flag is zeroYu Watanabe2024-04-111-55/+4
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This effectively reverts commit 155d7a2c049cf866a0bfde8de371f09dfb3b6f29. From RFC 4861 section 6.3.4: > Note, however, that a Prefix Information option with the on-link flag > set to zero conveys no information concerning on-link determination and > MUST NOT be interpreted to mean that addresses covered by the prefix > are off-link. So, we should not drop previously configured routes when receieved a RA with Prefix Information option without on-link flag. Closes #28435.
* | | resolved: use NULL to represent an empty answerRonan Pigott2024-04-111-8/+2
| | |
* | | vmspawn: enabled free page reporting in qemu by defaultSam Leonard2024-04-111-1/+2
| | | | | | | | | | | | | | | Fixes issue #32025, I saw no reason not to enable this by default so I added it to the initial qemu cmdline.
* | | Merge pull request #32213 from ↵Yu Watanabe2024-04-113-167/+136
|\ \ \ | | | | | | | | | | | | | | | | yuwata/network-ndisc-redirect-fix-sender-address-verification network/ndisc: fix sender address verification of Redirect message
| * | | sd-ndisc-redirect: fix verification of target addressYu Watanabe2024-04-111-4/+9
| | | | | | | | | | | | | | | | See RFC 4861 section 8.1.
| * | | network/ndisc: fix verification of sender of Redirect messageYu Watanabe2024-04-112-53/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sender must be the first-hop router of the destination. Previously, we only accepted Redirect messages whose sender is the current default router with the highest priority. See RFC 4861 section 8.1 for more details. Fixes #31981.
| * | | network/ndisc: split out ndisc_redirect_verify_sender()Yu Watanabe2024-04-111-8/+17
| | | | | | | | | | | | | | | | No functional change, preparation for later commits.
| * | | network/ndisc: drop ndisc_request_redirect_route()Yu Watanabe2024-04-111-28/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is now called by only ndisc_redirect_handler(), and the check in ndisc_request_redirect_route() is redundant and already done by ndisc_redirect_verify_sender(). No functional change, just refactoring.
| * | | network/ndisc: redirect routes do not have lifetimeYu Watanabe2024-04-111-25/+1
| | | | | | | | | | | | | | | | | | | | | | | | Hence, ndisc_router_update_redirect() does nothing. Let's remove it. Also, ndisc_request_route() does not set lifetime for the route, it is not necessary to set the third argument.
| * | | network/ndisc: introduce ndisc_request_router_route()Yu Watanabe2024-04-111-22/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Then, make ndisc_request_route() generic and usable for configuring routes based on both Router Advertisement and Redirect messages. Note, ndisc_request_router() never set lifetime, so the dropped comment in ndisc_request_redirect_route() is wrong. No functional change, just refactoring.
| * | | network/ndisc: do not set per-route MTU and hop limitYu Watanabe2024-04-112-32/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting MTU announced in RA message to routes is problematic, as the value may be larger than the device MTU (IFLA_MTU), and in such case the route cannot be used. These two properties are now set per-interface, and gracefully handled such invalid cases. Hence not necessary to set them to each route. Follow-up for #32195.
* | | | nsresourced: don't redefine of bpf_rdonly_castLudwig Nussel2024-04-111-0/+5
|/ / / | | | | | | | | | | | | | | | bpf_rdonly_cast() was introduced in libbpf commit 688879f together with the definition of a bpf_core_cast macro. So use that one to avoid defining a prototype for bpf_rdonly_cast;
* | | journal-remote: fix two minor memory leaksAntonio Alvarez Feijoo2024-04-112-0/+3
| | |
* | | Merge pull request #32228 from mrc0mmand/more-test-tweaksFrantisek Sumsal2024-04-114-49/+92
|\ \ \ | |/ / |/| | A couple of follow-ups for #32189
| * | test: make sd-journal-gatewayd tests even more debug-ableFrantisek Sumsal2024-04-111-45/+90
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unfortunately bfd30e8af6 is not enough and the test fails, that still occasionally occur, don't provide enough information to see what's wrong. Let's rework the test a little to improve this, namely: - redirect curl's output into a temporary file instead of piping it directly into the "check" expression; that way we can simply dump the temporary file when the test fails, providing potentially crucial information. We don't want to always dump everything to stdout, as some of the tests request an entire system journal (note that shell redirection instead of `curl -o file` is used intentionally, so the output file is always nuked first) - by dropping the pipes in curl commands we can re-enable pipefail - also, split some very long commands to multiple lines to (slightly) improve readability Follow-up for bfd30e8af64a0d39ad110258dca69be919f6df34.
| * | test: make the output of TEST-69 less painful to readFrantisek Sumsal2024-04-113-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The logs from TEST-69 still contain a lot of unnecessary shell metacharacters, so to make the output more readable let's just set TERM=dumb, instead of having to strip everything semi-manually. Also, move the related --background= tweak to TEST-69, since it's relevant only for that particular test. Follow-up for 8d4bfd38ed941aa8003d7007145eccc01f52a5f6.
* | | Merge pull request #32215 from yuwata/network-ndisc-address-lifetimeLuca Boccassi2024-04-111-31/+81
|\ \ \ | | | | | | | | network/ndisc: fix assignment of valid lifetime
| * | | network/ndisc: fix updating valid lifetime of configured addressYu Watanabe2024-04-111-21/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes the logic mostly follows RFC 4862 section 5.5.3 (e), as draft-ietf-6man-slaac-renum-07 is deprecated. Fixes #31449.
| * | | network/ndisc: set provider address in callerYu Watanabe2024-04-111-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | Follow-up for 43d184682d640e438ad140b0743e2fd258455b12. No functional change, just refactoring.
* | | | creds: allow null when decryptingLudwig Nussel2024-04-112-1/+17
| | | | | | | | | | | | | | | | | | | | pcrlock writes a credential file using null key. Make sure systemd-creds can show the file
* | | | Merge pull request #32216 from DaanDeMeyer/fixDaan De Meyer2024-04-116-80/+25
|\ \ \ \ | | | | | | | | | | journal-remote: Use sd_event_set_signal_exit()