summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* mount: strdup() device paths we collectLennart Poettering2018-12-071-3/+4
| | | | | | We never know what the changes triggered by mount_set_state() do to the unit. Let's be safe and copy the device path into our set, so that we are safe against that.
* mount: when the kernel reports a mount to be established reset all kinds of ↵Lennart Poettering2018-12-071-1/+3
| | | | | | | | load failures It doesn't matter what kind of precise failure we had earlier with loading the unit, let's report that it loaded successfully now, after all the kernel is an OK source for that, like any other.
* mount: regenerate all deps whenever a mount's parameters changesLennart Poettering2018-12-071-24/+10
| | | | | | | | | Whenever we notice a change on an existing /proc/self/mountinfo line, let's update the deps generated from it. For that, let's flush out the old deps generated this way, and add in the new ones. This takes benefit of the fact that today (unlike a comment this patch removes says) we can remove deps in a somewhat reasonable way.
* mount: when allocating a Mount object based on /proc/self/mountinfo mark it soLennart Poettering2018-12-071-0/+7
| | | | | | | Let's set 'from_proc_self_mountinfo' right away, since we know its from there. This is important so that when the load queue is dispatched (and thus mount_load() called) this fact is already known.
* mount: let mount_add_extras() take care of remote-fs.target depsLennart Poettering2018-12-071-16/+1
| | | | | | | | In a previous commit we added logic that mount_add_extras() (or more precisely mount_add_default_dependencies()) adds in dependencies on remote-fs.target and local-fs.target, hence we can drop this from mount_setup_new_unit() and let the usual load queue dispatching take care of this.
* mount: use free_and_strdup() over plain strdup()Lennart Poettering2018-12-071-6/+6
| | | | | | | Let's initialize two fields with free_and_strdup() rather than directly with strdup(). The fields should not be initialized so far, but it's still nicer to be prepared for futzre code changes and always free what's stored before replacing it.
* mount: generate error message matching the error locationLennart Poettering2018-12-071-4/+2
|
* mount: move allocation of Unit object into mount_setup_new_unit()Lennart Poettering2018-12-071-16/+18
| | | | This should encapsulate things in a nicer way.
* mount: add a common helper for filling in info from /proc/self/mountinfoLennart Poettering2018-12-071-19/+41
|
* mount: don't propagate errors from mount_setup_unit() further upLennart Poettering2018-12-071-6/+3
| | | | | | | | If we can't process a specific line in /proc/self/mountinfo we should log about it (which we do), but this should not affect other lines, nor further processing of mount units. Let's keep these failures local. Fixes: #10874
* mount: simplify de-serialization of control PID a bitLennart Poettering2018-12-071-4/+2
|
* mount: serialize umount retry counter across reloads/reexecLennart Poettering2018-12-071-1/+9
|
* mount: make sure mount_add_extras() is always invoked when we load a mount unitLennart Poettering2018-12-071-12/+17
| | | | | | | | | We need to make sure that the slice property is initialized whenever mount_load() is invoked, even if we fail to load things properly off disk. This is important since we generally don't allow changing the slice after a unit has been started. But given that we must track the state of external objects with mount units we must hence initialize the property no matter what.
* mount: document that mount_add_extras() must work with active units, tooLennart Poettering2018-12-071-0/+4
|
* mount: set up local-fs.target/remote-fs.target deps in ↵Lennart Poettering2018-12-071-3/+10
| | | | | | | | | | | mount_add_default_dependencies() too This deps are very similar to the -pre deps, hence establish them at the same place, in particular as they should only be generated if default deps are on. This allows us to later on remove similar code that adds in these deps whenever /proc/self/mountinfo changes.
* mount: remove unnecessary initialization of device_wants_mount and 'if'Lennart Poettering2018-12-071-3/+3
|
* mount: use mfree() where appropriateLennart Poettering2018-12-071-5/+3
|
* mount: rename needs_quota() → mount_needs_quota()Lennart Poettering2018-12-071-4/+4
| | | | | No change of logic, just some renaming, in order to match more closely the naming of the other, similar functions.
* mount: merge redundant call mount_needs_network() into mount_is_network()Lennart Poettering2018-12-071-9/+5
|
* travis: also compile systemd on Debian TestingEvgeny Vereshchagin2018-12-072-0/+101
| | | | This should help to catch issues like https://github.com/systemd/systemd/issues/11075
* man: fix reference to sd_journal_print(3)Filipe Brandenburger2018-12-071-2/+2
| | | | | | | | The reference in systemd-journald.service(8) was incorrectly pointing to man volume 4 instead of 3. This commit should fix the broken link at https://www.freedesktop.org/software/systemd/man/systemd-journald.service.html
* missing: re-add drm related entriesYu Watanabe2018-12-074-4/+12
| | | | | | This effectively reverts dab28f09051445fe370466e767e31652e0804a0f. Fixes #11075.
* bash-completion: analyze: support 'security'Yu Watanabe2018-12-071-1/+19
|
* Merge pull request #11072 from yuwata/fix-networkctl-ip6greZbigniew Jędrzejewski-Szmek2018-12-079-17/+24
|\ | | | | networkctl: fix TYPE field of ip6gre devices
| * missing: add ARPHRD_IP6GREYu Watanabe2018-12-071-0/+5
| | | | | | | | This fixes TYPE field of networkctl's output for ip6gre devices.
| * af-list,arphrd-list: also include relevant missing_*.h headersYu Watanabe2018-12-075-5/+8
| |
| * journal: use missing_audit.h to generate audit_type-list.txtYu Watanabe2018-12-074-11/+9
| |
| * cap-list: use missing_capabilty.h to generate list of capabilitiesYu Watanabe2018-12-071-1/+2
|/
* Merge pull request #11038 from keszybz/man-timeoutsYu Watanabe2018-12-074-13/+40
|\ | | | | Small improvements for documentation of timeout options
| * shared/generator: reword comment for clarityZbigniew Jędrzejewski-Szmek2018-12-031-4/+3
| |
| * man: add missing descriptions of fstab options to systemd.swap(5)Zbigniew Jędrzejewski-Szmek2018-12-032-3/+25
| |
| * man: split the descriptions of Job*TimeoutSec and JobTimeoutActionZbigniew Jędrzejewski-Szmek2018-12-031-6/+12
| | | | | | | | | | Those are really two different things, and it seems more natural to describe them as separate items.
* | systemctl: be nice to users and give hint how to specify "-.mount"Zbigniew Jędrzejewski-Szmek2018-12-071-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1656639 Using "--" is a trick that is hard to discover. Let's give users a hint: $ build/systemctl status -.service build/systemctl: invalid option -- '.' Hint: to specify units starting with a dash, use "--": build/systemctl [OPTIONS...] {COMMAND} -- -.service ... I use program_invocation_name because that's what getopt seems to use. "::" is used in the option string so that getopt doesn't complain about a missing argument in case somebody passes "-." as the argument. After all "." is not a real option.
* | shared/blkid-util: do not include util.h needlesslyZbigniew Jędrzejewski-Szmek2018-12-071-4/+2
| |
* | Revert "pager: close all fds when forking off pager"Yu Watanabe2018-12-061-1/+1
| | | | | | | | | | | | This reverts commit 55844aebb60b42f56335eb147dd395269d8fb686. As `exe_name_pipe` are closed by safe_fork().
* | Merge pull request #11056 from poettering/resolved-ifindexYu Watanabe2018-12-066-126/+150
|\ \ | | | | | | resolved: request incoming ifindex for DNS UDP packets, too
| * | logs-show: use grey color for de-emphasizing journal log outputLennart Poettering2018-12-051-0/+4
| | |
| * | resolvectl: color "comment" output greyLennart Poettering2018-12-052-9/+9
| | | | | | | | | | | | Let's de-emphasize the "comment" output a bit, by making it grey.
| * | resolvectl: add some basic highlighting to query outputLennart Poettering2018-12-051-6/+6
| | | | | | | | | | | | Let's highlight the actual payload the user requested.
| * | resolvectl: when doing reverse lookups, show ifindex as "comment" too in outputLennart Poettering2018-12-051-24/+15
| | | | | | | | | | | | | | | | | | | | | Similar as before: don't output ifindex twice on the same address, and show it as comment only. Do this for reverse lookup output and all other output too.
| * | resolvectl: fix interface output when resolving hostnames→addressesLennart Poettering2018-12-051-9/+21
| | | | | | | | | | | | | | | | | | | | | | | | We already used in_addr_ifindex_to_string() which internally appends the ifindex to the address with % if necessary. It's simply wrong to attach the intreface a second time with % then. Also, it breaks stuff that cannot deal with that. Hence, let's reformat this, and add the ifindex as a comment to the output, and drop the second % suffix.
| * | resolvectl: remove allow_loopback parameter from ifname_mangle()Lennart Poettering2018-12-053-21/+13
| | | | | | | | | | | | | | | | | | | | | All our bus calls validate whether the specified device is a loopback device anyway on the server side. Let's hence simplify the client, there's no value in optimizing error paths after all. But there is value in simpler code.
| * | resolvectl: for our per-link verbs alternatively accept interface name in -iLennart Poettering2018-12-051-46/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | it's a bit confusing that we take two interfaces for verbs such as "dns" or "domain": once after the verb, and once as --interface=. While there's logic behind it, let's make this least surprising: if either is specified be happy. This means "resolvectl -i foo dns" is now equivalent to "resolvectl dns foo …". Note that this is a tweak only, to minimize surprises. We don't document this alternative syntax, and shouldn't to keep things simple.
| * | resolvectl: rework ifname_mangle()Lennart Poettering2018-12-051-26/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's compare the ifname passed in with what is set already if there is something set already. Complain in that case. This makes commands such as "resolvectl -i foo dns bar" less weird, as we'll refuse the duplicate ifname specifications. Also, free the old arg_ifname right before assigning the new, instead of doing so in advance.
| * | resolved: request incoming ifindex for DNS UDP packets, tooLennart Poettering2018-12-051-3/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | This information is useful to pass back to the caller, as it tells us where we found the answer. (While we are at it, fix the socket level for the RECVERR logic) Fixes: #9778
* | | Merge pull request #11066 from yuwata/test-network-tiny-cleanupsYu Watanabe2018-12-061-89/+204
|\ \ \ | | | | | | | | test-network: several cleanups
| * | | test-network: make search_words_in_file() hit multi wordsYu Watanabe2018-12-061-14/+15
| | | |
| * | | test-network: delete rules before running next testYu Watanabe2018-12-061-0/+6
| | | |
| * | | test-network: add a line break after starting networkdYu Watanabe2018-12-061-0/+1
| | | | | | | | | | | | | | | | | | | | This may be ugly. But otherwise, outputs of several check commands are shown without new line...
| * | | test-network: check link before starting dnsmasqYu Watanabe2018-12-061-27/+18
| | | |