| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
We never know what the changes triggered by mount_set_state() do to the
unit. Let's be safe and copy the device path into our set, so that we
are safe against that.
|
|
|
|
|
|
|
|
| |
load failures
It doesn't matter what kind of precise failure we had earlier with
loading the unit, let's report that it loaded successfully now, after
all the kernel is an OK source for that, like any other.
|
|
|
|
|
|
|
|
|
| |
Whenever we notice a change on an existing /proc/self/mountinfo line,
let's update the deps generated from it. For that, let's flush out the
old deps generated this way, and add in the new ones.
This takes benefit of the fact that today (unlike a comment this patch
removes says) we can remove deps in a somewhat reasonable way.
|
|
|
|
|
|
|
| |
Let's set 'from_proc_self_mountinfo' right away, since we know its from
there. This is important so that when the load queue is dispatched (and
thus mount_load() called) this
fact is already known.
|
|
|
|
|
|
|
|
| |
In a previous commit we added logic that mount_add_extras() (or more
precisely mount_add_default_dependencies()) adds in dependencies on
remote-fs.target and local-fs.target, hence we can drop this from
mount_setup_new_unit() and let the usual load queue dispatching take
care of this.
|
|
|
|
|
|
|
| |
Let's initialize two fields with free_and_strdup() rather than directly
with strdup(). The fields should not be initialized so far, but it's
still nicer to be prepared for futzre code changes and always free
what's stored before replacing it.
|
| |
|
|
|
|
| |
This should encapsulate things in a nicer way.
|
| |
|
|
|
|
|
|
|
|
| |
If we can't process a specific line in /proc/self/mountinfo we should
log about it (which we do), but this should not affect other lines, nor
further processing of mount units. Let's keep these failures local.
Fixes: #10874
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
We need to make sure that the slice property is initialized whenever
mount_load() is invoked, even if we fail to load things properly off
disk. This is important since we generally don't allow changing the
slice after a unit has been started. But given that we must track the
state of external objects with mount units we must hence initialize the
property no matter what.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
mount_add_default_dependencies() too
This deps are very similar to the -pre deps, hence establish them at the
same place, in particular as they should only be generated if default
deps are on.
This allows us to later on remove similar code that adds in these deps
whenever /proc/self/mountinfo changes.
|
| |
|
| |
|
|
|
|
|
| |
No change of logic, just some renaming, in order to match more closely
the naming of the other, similar functions.
|
| |
|
|
|
|
| |
This should help to catch issues like https://github.com/systemd/systemd/issues/11075
|
|
|
|
|
|
|
|
| |
The reference in systemd-journald.service(8) was incorrectly pointing to
man volume 4 instead of 3.
This commit should fix the broken link at
https://www.freedesktop.org/software/systemd/man/systemd-journald.service.html
|
|
|
|
|
|
| |
This effectively reverts dab28f09051445fe370466e767e31652e0804a0f.
Fixes #11075.
|
| |
|
|\
| |
| | |
networkctl: fix TYPE field of ip6gre devices
|
| |
| |
| |
| | |
This fixes TYPE field of networkctl's output for ip6gre devices.
|
| | |
|
| | |
|
|/ |
|
|\
| |
| | |
Small improvements for documentation of timeout options
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Those are really two different things, and it seems more natural to describe them
as separate items.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
https://bugzilla.redhat.com/show_bug.cgi?id=1656639
Using "--" is a trick that is hard to discover. Let's give users a hint:
$ build/systemctl status -.service
build/systemctl: invalid option -- '.'
Hint: to specify units starting with a dash, use "--":
build/systemctl [OPTIONS...] {COMMAND} -- -.service ...
I use program_invocation_name because that's what getopt seems to use.
"::" is used in the option string so that getopt doesn't complain about
a missing argument in case somebody passes "-." as the argument. After all
"." is not a real option.
|
| | |
|
| |
| |
| |
| |
| |
| | |
This reverts commit 55844aebb60b42f56335eb147dd395269d8fb686.
As `exe_name_pipe` are closed by safe_fork().
|
|\ \
| | |
| | | |
resolved: request incoming ifindex for DNS UDP packets, too
|
| | | |
|
| | |
| | |
| | |
| | | |
Let's de-emphasize the "comment" output a bit, by making it grey.
|
| | |
| | |
| | |
| | | |
Let's highlight the actual payload the user requested.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Similar as before: don't output ifindex twice on the same address, and
show it as comment only.
Do this for reverse lookup output and all other output too.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We already used in_addr_ifindex_to_string() which internally appends the
ifindex to the address with % if necessary. It's simply wrong to attach the
intreface a second time with % then. Also, it breaks stuff that cannot
deal with that. Hence, let's reformat this, and add the ifindex as a
comment to the output, and drop the second % suffix.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
All our bus calls validate whether the specified device is a loopback
device anyway on the server side. Let's hence simplify the client,
there's no value in optimizing error paths after all. But there is value
in simpler code.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
it's a bit confusing that we take two interfaces for verbs such as "dns"
or "domain": once after the verb, and once as --interface=. While
there's logic behind it, let's make this least surprising: if either is
specified be happy.
This means "resolvectl -i foo dns" is now equivalent to "resolvectl dns
foo …". Note that this is a tweak only, to minimize surprises. We don't
document this alternative syntax, and shouldn't to keep things simple.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Let's compare the ifname passed in with what is set already if there is
something set already. Complain in that case. This makes commands such
as "resolvectl -i foo dns bar" less weird, as we'll refuse the duplicate
ifname specifications.
Also, free the old arg_ifname right before assigning the new, instead of
doing so in advance.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This information is useful to pass back to the caller, as it tells us
where we found the answer.
(While we are at it, fix the socket level for the RECVERR logic)
Fixes: #9778
|
|\ \ \
| | | |
| | | | |
test-network: several cleanups
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This may be ugly. But otherwise, outputs of several check commands
are shown without new line...
|
| | | | |
|