| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
They are various cases where the same module might be repeatedly
loaded in a short time frame, for example if a service depending on a
module keep restarting, or if many instances of such service get
started at the same time. If this happend the modprobe@.service
instance will be marked as failed because it hit the restart limit.
Overall it doesn't seems to make much sense to have a restart limit on
the modprobe service so just disable it.
Fixes: #23742
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Fixes build with musl:
| ../git/src/shared/dissect-image.c: In function 'mount_image_privately_interactively':
| ../git/src/shared/dissect-image.c:2986:34: error: 'LOCK_SH' undeclared (first use in this function)
| 2986 | r = loop_device_flock(d, LOCK_SH);
| | ^~~~~~~
|
| |
| |
| |
| | |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2098553.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As the `%%` specifier might fail if the current job (i.e. the last
background job) already finished:
```
[ 61.692196] testsuite-04.sh[656]: ++ systemd-id128 new
[ 61.705407] testsuite-04.sh[263]: + ID=912cb8f8ef304153a123f772bb0fe9e0
[ 61.706318] testsuite-04.sh[657]: + systemd-cat -t 912cb8f8ef304153a123f772bb0fe9e0 bash -c 'echo parent; (echo child) & wait'
[ 61.720940] testsuite-04.sh[263]: + PID=657
[ 61.721126] testsuite-04.sh[263]: + wait %%
[ 61.723014] testsuite-04.sh[263]: /usr/lib/systemd/tests/testdata/units/testsuite-04.sh: line 96: wait: %%: no such job
```
|
|\ \
| | |
| | | |
test: fuzz our dbus interfaces with dfuzzer
|
| | |
| | |
| | |
| | |
| | | |
as the test is quite time consuming and it yields more useful reports
when the target app is built with sanitizers.
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
Fixes a bug introduced by 3d36b5d7e7b191fca7c5c65dbab94d99cf5f0230.
Fixes #23777.
|
|\ \
| | |
| | | |
A couple of test-output-related tweaks
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
since we delete the guest journals as part of the save_journal() step in
check_result_common(), making journal inaccessible from the custom check
hooks.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Let's keep the debug logs in the journal, while logging only
testsute-*.sh stdout/stderr to the console (ba7abf7). This should make
the test output log a bit more readable and potentially the tests itself
a bit faster by avoiding console oversaturation.
Also, it should significantly reduce the size of artifacts kept by CIs.
|
| | |
| | |
| | |
| | | |
since they dlopen() PAM modules, including systemd ones.
|
| | |
| | |
| | |
| | | |
as it unnecessarily clogs the logs.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Commit 0307afc681e1 ("networkctl: add support to display Transmit/Recieve queue
length (#12633)") added the display of the number of RX and TX Queues to the
output of `networkctl status $DEV`. However the row description says "Queue
Length".
This patch fixes the output by replacing "Queue Length" by "Number of Queues".
Fixes: 0307afc681e1 ("networkctl: add support to display Transmit/Recieve queue length (#12633)")
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| | |
analyze: fix seccomp filter handling in security command
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
@known is generated from syscall-list.txt, which generated from kernel
headers. So, some syscalls in @obsolete may not be listed in
syscall-list.txt.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts dd51e725df9aec2847482131ef601e0215b371a0 and fixes bugs
introduced by 1624114d74f55ad9791b7624b08d89d2339a68b3.
Previously,
- On online scan, the syscall filter was a string Hashmap, but it
might contain syscall name with errno or error action. Hence, we need
to drop the errno or error action in the string.
- On offline scan, the syscall filter was a Hashmap of syscall ID, so
hashmap_contains() with syscall name did not work. We need to convert
syscall IDs to syscall names.
- If hashmap_contains() in syscall_names_in_filter() is true, then
the syscall is allowed when the list is an allow-list, and vice versa.
Hence, the condition in syscall_names_in_filter() was errnously
inverted by dd51e725df9aec2847482131ef601e0215b371a0.
This makes syscalls are always stored with its name, instead of ID,
and also correct the condition.
Fixes #23663.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Note, if `n != SIZE_MAX`, we cannot check the existence of the specified
string in the set without duplicating the string. And, set_consume() also
checks the existence of the string. Hence, it is not necessary to call
set_contains() if `n != SIZE_MAX`.
|
| | |
| | |
| | |
| | |
| | | |
The code block is called only when the list was empty, and the newly
requested list is allow-list. Hence, invert_flag is always zero here.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Follow-up for 68acc1afbe5cec50da1ffdc411dadda504e4caf5.
Before the commit, SystemCallFilter bus property provides only allowed
syscalls if ExecContext.syscall_filter is an allow-list, and vice versa.
After the commit, if the list is allow-list, it contains allowed
syscalls with value `-1`, and denied syscalls with non-negative values.
To keep the backward compatibility, denied syscalls must be dropped in
SystemCallFilter bus property.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently, -Wall and -Wextra override previously passed flags like
-Wno-unused-parameter. This reorders them to be passed before any
optional flags. -Wsign-compare is part of -Wextra and therefore dropped.
-nostdlib is a link-stage flag and dropped as it is already part of
efi_ldflags.
|
| | |
| | |
| | |
| | | |
to make debugging in CIs slightly easier.
|
|\ \ \
| | | |
| | | | |
test: wrap certain uninstrumented binaries to make them work w/ ASan
|
| | | |
| | | |
| | | |
| | | |
| | | | |
since they should handle loading other instrumented libraries without
issues.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
since they shouldn't be necessary anymore, as we tweak the "problematic"
binaries on per-binary basis.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Let's detect & wrap binaries which are linked against systemd DSOs and
we're running under ASan, since otherwise running such binaries ends
with:
```
==633==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.
```
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit 47d81bc61315bae917276f978f39f200cf31e106.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We send/recv the set of payload uid, host uid, payload gid, host gid.
Hence, the index must be incremented with 4, instead of 2.
Fixes #23664.
|
| | | |
| | | |
| | | |
| | | | |
Known-Answer list whose remaining TTL is less than half of their original TTL
|
| |/ /
|/| |
| | |
| | |
| | | |
RFC 6762 does not restrict caching of records in the Additional section.
Caching can improve resolve efficiency.
|
| | | |
|
|\ \ \
| | | |
| | | | |
homework: initialize we_detached
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes: CID#1469712
CID 1469712 (#1 of 1): Unused value (UNUSED_VALUE)
returned_value: Assigning value from sd_id128_from_string(word + 2, &boot_id) to r here,
but that stored value is overwritten before it can be used.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes: CID#1469711
CID 1469711 (#1 of 1): Uninitialized scalar variable (UNINIT)
14. uninit_use: Using uninitialized value we_detached.
|
|\ \ \ \
| |_|/ /
|/| | | |
test: import hostname and locale tests from debian/ubuntu test suite
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Now it also supports split-usr.
|