summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | units: remove the restart limit on the modprobe@.serviceAlban Bedel2022-06-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They are various cases where the same module might be repeatedly loaded in a short time frame, for example if a service depending on a module keep restarting, or if many instances of such service get started at the same time. If this happend the modprobe@.service instance will be marked as failed because it hit the restart limit. Overall it doesn't seems to make much sense to have a restart limit on the modprobe service so just disable it. Fixes: #23742
* | | Add sys/file.h for LOCK_Pavel Zhukov2022-06-215-0/+5
|/ / | | | | | | | | | | | | | | Fixes build with musl: | ../git/src/shared/dissect-image.c: In function 'mount_image_privately_interactively': | ../git/src/shared/dissect-image.c:2986:34: error: 'LOCK_SH' undeclared (first use in this function) | 2986 | r = loop_device_flock(d, LOCK_SH); | | ^~~~~~~
* | pkgconfig,rpm: expose vars for user-tmpfiles.d locationZbigniew Jędrzejewski-Szmek2022-06-213-0/+5
| | | | | | | | Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2098553.
* | test: use saved process PID instead of %%Frantisek Sumsal2022-06-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | As the `%%` specifier might fail if the current job (i.e. the last background job) already finished: ``` [ 61.692196] testsuite-04.sh[656]: ++ systemd-id128 new [ 61.705407] testsuite-04.sh[263]: + ID=912cb8f8ef304153a123f772bb0fe9e0 [ 61.706318] testsuite-04.sh[657]: + systemd-cat -t 912cb8f8ef304153a123f772bb0fe9e0 bash -c 'echo parent; (echo child) & wait' [ 61.720940] testsuite-04.sh[263]: + PID=657 [ 61.721126] testsuite-04.sh[263]: + wait %% [ 61.723014] testsuite-04.sh[263]: /usr/lib/systemd/tests/testdata/units/testsuite-04.sh: line 96: wait: %%: no such job ```
* | Merge pull request #22547 from mrc0mmand/dfuzzerEvgeny Vereshchagin2022-06-206-3/+139
|\ \ | | | | | | test: fuzz our dbus interfaces with dfuzzer
| * | test: skip TEST-21-DFUZZER without ASanFrantisek Sumsal2022-06-191-0/+5
| | | | | | | | | | | | | | | as the test is quite time consuming and it yields more useful reports when the target app is built with sanitizers.
| * | test: fuzz our dbus interfaces with dfuzzerFrantisek Sumsal2022-06-195-0/+130
| | |
| * | test: make masking of supplementary services configurableFrantisek Sumsal2022-06-192-3/+4
|/ /
* | locale: drop unnecessary allocationYu Watanabe2022-06-181-4/+0
| | | | | | | | | | | | Fixes a bug introduced by 3d36b5d7e7b191fca7c5c65dbab94d99cf5f0230. Fixes #23777.
* | Merge pull request #23771 from mrc0mmand/test-tweaksYu Watanabe2022-06-1820-46/+29
|\ \ | | | | | | A couple of test-output-related tweaks
| * | test: check journal directly instead of capturing console outputFrantisek Sumsal2022-06-171-9/+4
| | |
| * | test: run the custom check hooks before common checksFrantisek Sumsal2022-06-171-8/+8
| | | | | | | | | | | | | | | | | | since we delete the guest journals as part of the save_journal() step in check_result_common(), making journal inaccessible from the custom check hooks.
| * | test: pass the initdir to check_result_{qemu,nspawn} hooksFrantisek Sumsal2022-06-171-4/+4
| | |
| * | test: fix a couple of issues found by shellcheckFrantisek Sumsal2022-06-172-6/+6
| | |
| * | test: don't flush debug logs to the consoleFrantisek Sumsal2022-06-1717-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Let's keep the debug logs in the journal, while logging only testsute-*.sh stdout/stderr to the console (ba7abf7). This should make the test output log a bit more readable and potentially the tests itself a bit faster by avoiding console oversaturation. Also, it should significantly reduce the size of artifacts kept by CIs.
| * | test: always wrap useradd/userdel when running w/ ASanFrantisek Sumsal2022-06-171-2/+2
| | | | | | | | | | | | since they dlopen() PAM modules, including systemd ones.
| * | test: make the busy loop in TEST-02 less verboseFrantisek Sumsal2022-06-171-0/+5
| | | | | | | | | | | | as it unnecessarily clogs the logs.
* | | networkctl: fix output of "status": replace "Queue Length" by "Number of Queues"Marc Kleine-Budde2022-06-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 0307afc681e1 ("networkctl: add support to display Transmit/Recieve queue length (#12633)") added the display of the number of RX and TX Queues to the output of `networkctl status $DEV`. However the row description says "Queue Length". This patch fixes the output by replacing "Queue Length" by "Number of Queues". Fixes: 0307afc681e1 ("networkctl: add support to display Transmit/Recieve queue length (#12633)")
* | | add program name to log linePhilipp Gortan2022-06-181-1/+1
| | |
* | | cryptenroll: fix typo in manpageFoster Snowhill2022-06-181-1/+1
| | |
* | | Merge pull request #23756 from yuwata/analyze-seccomp-filterLuca Boccassi2022-06-177-26/+132
|\ \ \ | |/ / |/| | analyze: fix seccomp filter handling in security command
| * | test: add syscall filter tests for analyze securityYu Watanabe2022-06-171-0/+60
| | |
| * | seccomp-util: make @known include @obsoleteYu Watanabe2022-06-171-0/+1
| | | | | | | | | | | | | | | | | | @known is generated from syscall-list.txt, which generated from kernel headers. So, some syscalls in @obsolete may not be listed in syscall-list.txt.
| * | analyze-security: always save syscall nameYu Watanabe2022-06-171-17/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts dd51e725df9aec2847482131ef601e0215b371a0 and fixes bugs introduced by 1624114d74f55ad9791b7624b08d89d2339a68b3. Previously, - On online scan, the syscall filter was a string Hashmap, but it might contain syscall name with errno or error action. Hence, we need to drop the errno or error action in the string. - On offline scan, the syscall filter was a Hashmap of syscall ID, so hashmap_contains() with syscall name did not work. We need to convert syscall IDs to syscall names. - If hashmap_contains() in syscall_names_in_filter() is true, then the syscall is allowed when the list is an allow-list, and vice versa. Hence, the condition in syscall_names_in_filter() was errnously inverted by dd51e725df9aec2847482131ef601e0215b371a0. This makes syscalls are always stored with its name, instead of ID, and also correct the condition. Fixes #23663.
| * | set: introduce set_put_strndup()Yu Watanabe2022-06-173-8/+44
| | | | | | | | | | | | | | | | | | | | | Note, if `n != SIZE_MAX`, we cannot check the existence of the specified string in the set without duplicating the string. And, set_consume() also checks the existence of the string. Hence, it is not necessary to call set_contains() if `n != SIZE_MAX`.
| * | core/dbus-execute: drop unnecessary flagYu Watanabe2022-06-171-1/+1
| | | | | | | | | | | | | | | The code block is called only when the list was empty, and the newly requested list is allow-list. Hence, invert_flag is always zero here.
| * | core/dbus-execute: do not append denied syscalls in allow-listYu Watanabe2022-06-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-up for 68acc1afbe5cec50da1ffdc411dadda504e4caf5. Before the commit, SystemCallFilter bus property provides only allowed syscalls if ExecContext.syscall_filter is an allow-list, and vice versa. After the commit, if the list is allow-list, it contains allowed syscalls with value `-1`, and denied syscalls with non-negative values. To keep the backward compatibility, denied syscalls must be dropped in SystemCallFilter bus property.
* | | meson: Reorder cflags for sd-bootJan Janssen2022-06-171-19/+17
| | | | | | | | | | | | | | | | | | | | | | | | Currently, -Wall and -Wextra override previously passed flags like -Wno-unused-parameter. This reorders them to be passed before any optional flags. -Wsign-compare is part of -Wextra and therefore dropped. -nostdlib is a link-stage flag and dropped as it is already part of efi_ldflags.
* | | test: send stdout/stderr of testsuite units to journal & consoleFrantisek Sumsal2022-06-177-12/+12
| | | | | | | | | | | | to make debugging in CIs slightly easier.
* | | Merge pull request #23741 from mrc0mmand/more-asan-tweaksYu Watanabe2022-06-162-57/+48
|\ \ \ | | | | | | | | test: wrap certain uninstrumented binaries to make them work w/ ASan
| * | | test: don't wrap binaries built with ASanFrantisek Sumsal2022-06-161-3/+7
| | | | | | | | | | | | | | | | | | | | since they should handle loading other instrumented libraries without issues.
| * | | test: drop all LD_PRELOAD-related ASan workaroundsFrantisek Sumsal2022-06-161-53/+1
| | | | | | | | | | | | | | | | | | | | since they shouldn't be necessary anymore, as we tweak the "problematic" binaries on per-binary basis.
| * | | test: wrap binaries using systemd DSOs when running w/ ASanFrantisek Sumsal2022-06-161-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Let's detect & wrap binaries which are linked against systemd DSOs and we're running under ASan, since otherwise running such binaries ends with: ``` ==633==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD. ```
| * | | Revert "test: fix TEST-70 under sanitizers"Frantisek Sumsal2022-06-141-1/+2
| | | | | | | | | | | | | | | | This reverts commit 47d81bc61315bae917276f978f39f200cf31e106.
* | | | nspawn: fix UID map stringYu Watanabe2022-06-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We send/recv the set of payload uid, host uid, payload gid, host gid. Hence, the index must be incremented with 4, instead of 2. Fixes #23664.
* | | | RFC 6762 section 7.1: a Multicast DNS querier SHOULD NOT include records in theVishal Chillara Srinivas2022-06-161-0/+8
| | | | | | | | | | | | | | | | Known-Answer list whose remaining TTL is less than half of their original TTL
* | | | resolve: mark mDNS RRs in the Additional Records section as cacheableVishal Chillara Srinivas2022-06-161-2/+6
| |/ / |/| | | | | | | | | | | RFC 6762 does not restrict caching of records in the Additional section. Caching can improve resolve efficiency.
* | | tree-wide: fix typoYu Watanabe2022-06-152-2/+2
| | |
* | | Merge pull request #23733 from sshedi/cid-1469711Yu Watanabe2022-06-152-7/+6
|\ \ \ | | | | | | | | homework: initialize we_detached
| * | | sd-journal: check retval of sd_id128_from_string callShreenidhi Shedi2022-06-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: CID#1469712 CID 1469712 (#1 of 1): Unused value (UNUSED_VALUE) returned_value: Assigning value from sd_id128_from_string(word + 2, &boot_id) to r here, but that stored value is overwritten before it can be used.
| * | | homework: initialize we_detachedShreenidhi Shedi2022-06-141-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: CID#1469711 CID 1469711 (#1 of 1): Uninitialized scalar variable (UNINIT) 14. uninit_use: Using uninitialized value we_detached.
* | | | Merge pull request #23709 from yuwata/test-hostname-localeYu Watanabe2022-06-1529-433/+1101
|\ \ \ \ | |_|/ / |/| | | test: import hostname and locale tests from debian/ubuntu test suite
| * | | test: use trap RETURNYu Watanabe2022-06-142-16/+4
| | | |
| * | | test: move "do" at the end of lineYu Watanabe2022-06-141-6/+3
| | | |
| * | | test: insert space in for loopYu Watanabe2022-06-145-12/+12
| | | |
| * | | test: import localed tests from debian/ubuntu test suiteYu Watanabe2022-06-144-0/+412
| | | |
| * | | test: install C.UTF-8 and English localesYu Watanabe2022-06-141-0/+24
| | | |
| * | | test: install libxkbcommon and x11 keymapsYu Watanabe2022-06-141-1/+18
| | | |
| * | | test: introduce inst_recursive() helper functionYu Watanabe2022-06-141-0/+14
| | | |
| * | | test: add one more path to search keymapsYu Watanabe2022-06-141-19/+40
| | | | | | | | | | | | | | | | Now it also supports split-usr.