summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* man: fix links to man pagesZbigniew Jędrzejewski-Szmek2023-02-095-19/+20
| | | | Done using linkchecker as usual.
* man: fix section numberZbigniew Jędrzejewski-Szmek2023-02-091-2/+2
| | | | Fixes #26376.
* hwdb: Add HP Envy x360 Convertible 15-cn0xxx to existing entryFabian Gurtner2023-02-081-1/+2
|
* core: imply DeviceAllow=/dev/tpmrm0 with LoadCredentialEncryptedLuca Boccassi2023-02-083-1/+23
| | | | | | | If the device access policy is restricted, add implicitly access to the TPM if at least one encrypted credential needs to be loaded. Fixes https://github.com/systemd/systemd/issues/26042
* cryptenroll: do not implicitly verify with default tpm policy signatureLuca Boccassi2023-02-082-2/+9
| | | | | | | | If it was not requested to use a tpm2 signature file when enrolling, do not fallback to the default /run/systemd/tpm2-pcr-signature.json as it likely will be unrelated if it exists. Fixes https://github.com/systemd/systemd/issues/25435
* unit: always return 1 in log_killmsizanoen12023-02-081-1/+3
| | | | | This ensures that cg_kill_items returns the correct value to let the manager know that a process was killed.
* Merge pull request #26328 from yuwata/udev-worker-set-process-nameZbigniew Jędrzejewski-Szmek2023-02-088-30/+9
|\ | | | | udev: set worker process name
| * tree-wide: set FORK_RLIMIT_NOFILE_SAFE flagYu Watanabe2023-02-077-29/+8
| | | | | | | | No functional changes, just refactoring.
| * udevd: configure a child process name for worker processesYu Watanabe2023-02-071-1/+1
| | | | | | | | | | | | | | | | | | This effectively reverts commit ff86c92e3043f71fc801cf687600a480ee8f6778, and re-apply 49f3ee7e74c714f55aab395c080b1099fc17f7fd. The change was dropped due to the process name was not correctly logged, but the issue was fixed by dd15e4cb57129b915e01495e113696bfe0b70214. Let's set the child process name again.
* | journal: minor modernizationsLennart Poettering2023-02-071-12/+7
| |
* | Merge pull request #26337 from poettering/journal-display-tsLuca Boccassi2023-02-072-68/+94
|\ \ | | | | | | logs-show: rename "ts" paramater/variable to "display_ts"
| * | logs-show: rename "ts" paramater/variable to "display_ts"Lennart Poettering2023-02-072-68/+94
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When displaying log data we deal with two kind of timestamps: the one we use for display (typically the source timestamp if available), and the one we use internally (typically the reception timestamp of journald). The user-facing output modes generally use the display timestamp, the ones intended for further processing (i.e. json + export outputs) do not, and directly query the timestamps of the entry, ignoring the source. This gets a bit confusing, since it's not always clear why we use which timestamp where. Let's address that by renaming the generic "ts" parameter/variable to "display_ts" to emphasize that the stored timestamp are "corrected" timestamps for display only. No real code change, just some renaming.
* | Merge pull request #26336 from poettering/journal-etoomanyrefsLuca Boccassi2023-02-074-2/+10
|\ \ | | | | | | journal: print nicer log message when limit of open journal files during display is hit
| * | update TODOLennart Poettering2023-02-071-0/+4
| | |
| * | journal: print a useful error message if we hit the journal file open limitLennart Poettering2023-02-073-2/+6
| |/ | | | | | | See: #20921
* | Merge pull request #26335 from keszybz/dns-not-foundLuca Boccassi2023-02-075-37/+63
|\ \ | | | | | | resolve: adjust message for NXDOMAIN lookup result
| * | resolve: adjust message for NXDOMAIN lookup resultZbigniew Jędrzejewski-Szmek2023-02-072-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, we reported: nx.example.org: resolve call failed: 'nx.example.org' not found But the call did succeed, and in fact all communication with the upstream servers was successful, and we got an authoritative negative answer. So instead of saying that the call fail, just say that the host doesn't exist: nx.example.org: Name 'nx.example.org' not found I wanted to keep the prefix of "<name>: ", to keep the output uniform. But it'd look a bit strange to say "<name>: <name> not found", so I added "Name " to make the output more readable. (Another option would be to not display the error string received from resolved, but that seems risky: even if right now resolved uses just one message format, it could start doing something else in the future, so it's better to display the error as received.) Fixes #26233.
| * | resolve: define normal macros for BUS_ERROR_DNS error codesZbigniew Jędrzejewski-Szmek2023-02-074-36/+55
| |/ | | | | | | | | | | This result is identical after cpp is done, so we don't save anything by not having the usual macros. And with the usual macros it's easier to grep and code-crossreferencing works better.
* | Fix Positivo-vaio VJPW12F11X key toggle touchpaddrosdeck2023-02-071-2/+2
| |
* | Merge pull request #26338 from jamacku/fix-labelingZbigniew Jędrzejewski-Szmek2023-02-071-2/+2
|\ \ | |/ |/| ci: Fix automatic removing of labels when PR is closed
| * ci: remove `if: github.event.issue.pull_request` from `labeler.yml`Jan Macku2023-02-071-1/+1
| | | | | | | | | | | | | | `github.event.issue.pull_request` is an object, not a boolean. This is the root cause of why the step that is supposed to remove labels is always skipped. Having this condition in place is not necessary since the workflow is run on the `pull_request_target` event.
| * ci: fix missing quotes in `labeler.yml`Jan Macku2023-02-071-1/+1
|/
* Merge pull request #26324 from yuwata/argv-util-update-short-nameYu Watanabe2023-02-073-1/+6
|\ | | | | argv-util: also update short invocation name
| * argv-util: also update program_invocation_short_nameYu Watanabe2023-02-061-0/+4
| | | | | | | | | | | | Our logging uses program_invocation_short_name. Without this patch, logs from forked client may become broken; spuriously truncated or the short invocation name is not completely shown in the log.
| * test: use notice log level to make easily filter out logs from PID1Yu Watanabe2023-02-062-1/+2
| |
* | Merge pull request #26322 from keszybz/log-errno-fixYu Watanabe2023-02-071-2/+3
|\ \ | | | | | | Log errno fix
| * | repart: silence bogus gcc warningZbigniew Jędrzejewski-Szmek2023-02-061-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [2/3] Compiling C object systemd-repart.p/src_partition_repart.c.o ../src/partition/repart.c: In function ‘context_open_copy_block_paths’: ../src/partition/repart.c:5194:41: warning: ‘devno’ may be used uninitialized [-Wmaybe-uninitialized] 5194 | source_fd = r = device_open_from_devnum(S_IFBLK, devno, O_RDONLY|O_CLOEXEC|O_NONBLOCK, &opened); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/partition/repart.c:5188:31: note: ‘devno’ was declared here 5188 | dev_t devno; | ^~~~~ This is with gcc-13.0.1-0.2.fc38.x86_64, -O2. I'm pretty sure the code is correct. I also tried adding some asserts where errno is used for the return value, but that didn't help. I think resolve_copy_blocks_auto() is just too long for gcc to understand.
| * | repart: fix invalid errno in logZbigniew Jędrzejewski-Szmek2023-02-061-1/+1
| |/
* | Merge pull request #26321 from keszybz/flex-arraysYu Watanabe2023-02-0711-331/+704
|\ \ | | | | | | Enable new compiler diagnostics for invalid array accesses
| * | meson: enable -Wzero-length-boundsZbigniew Jędrzejewski-Szmek2023-02-061-0/+1
| | | | | | | | | | | | | | | | | | This will warn if fake flexible arrays are re-introduced. I'm not using -Werror=… because we may still get warnings when compiling against old kernel headers. We can crank this up to error later.
| * | meson: enable -Warray-bounds and -fstrict-flex-arraysZbigniew Jędrzejewski-Szmek2023-02-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | -fstrict-flex-arrays means that the compiler doesn't have to assume that any trailing array is a flex array. I.e. unless the array is declared without a specified size, only indices in the declared range are valid. -Warray-bounds turns on the warnings about out-of-bounds array accesses. -Warray-bounds=2 does some more warnings, with higher false positive rate. But it doesn't seem to yield any false positives in our codebase, so enable it. clang supports -Warray-bounds, but not -Warray-bounds=2. gcc supports both. gcc-13 supports -fstrict-flex-arrays. See https://people.kernel.org/kees/bounded-flexible-arrays-in-c for a long discussion of use in the kernel.
| * | shared/json: avoid use of fake flex arrayZbigniew Jędrzejewski-Szmek2023-02-061-11/+6
| | |
| * | sd-journal: avoid use of fake flex arraysZbigniew Jędrzejewski-Szmek2023-02-062-18/+36
| | | | | | | | | | | | | | | | | | I tried to use DECLARE_FLEX_ARRAY like the kernel does, but it does not work for anonymous structs (they cannot be declared inline), so an open-coded version is used.
| * | shared/linux: fix fake flexible array in struct autofs_dev_ioctlZbigniew Jędrzejewski-Szmek2023-02-062-1/+2
| | | | | | | | | | | | The kernel still hasn't fixed this in kernel-headers-6.2.0-0.rc6.git0.1.fc38.x86_64.
| * | sd-network: stop using fake flexible arrayZbigniew Jędrzejewski-Szmek2023-02-061-1/+1
| | |
| * | shared/linux: update kernel headersZbigniew Jędrzejewski-Szmek2023-02-066-300/+654
| |/ | | | | | | | | | | | | | | | | | | The kernel was updated to not use fake flex arrays with zero size. Updating should allow -fstrict-flex-arrays to be used. Headers pulled from kernel-headers-6.2.0-0.rc6.git0.1.fc38.x86_64. Note that this is not a straighforward copy: our files have local modifications (listed in README) that need to be preserved.
* | Merge pull request #26320 from keszybz/operator-whitespaceYu Watanabe2023-02-0739-95/+100
|\ \ | | | | | | Drop whitespace after shell redirection operators
| * | docs/CODING_STYLE: add sentence about redirection operatorsZbigniew Jędrzejewski-Szmek2023-02-061-2/+5
| | |
| * | tools: replace multi-line echo by <<EOFZbigniew Jędrzejewski-Szmek2023-02-061-2/+4
| | |
| * | test: drop whitespace after shell redirection operatorsZbigniew Jędrzejewski-Szmek2023-02-0638-91/+91
| |/ | | | | | | | | | | | | | | | | | | (The one case that is left unchanged is '< <(subcommand)'.) This way, the style with no gap was already dominant. This way, the reader immediately knows that ' < ' is a comparison operator and ' << ' is a shift. In a few cases, replace custom EOF replacement by just EOF. There is no point in using someting like "_EOL" unless "EOF" appears in the text.
* | NEWS: fix typoTopi Miettinen2023-02-061-1/+1
| |
* | update TODOLennart Poettering2023-02-061-23/+40
|/
* NEWS: adjust commas, avoid double negativeZbigniew Jędrzejewski-Szmek2023-02-061-9/+10
| | | | Also adjust text wrapping in a few spots.
* Add hwdb sensor entry for Lenovo IdeaPad Duet 3 10IGL5 (82AT).Darrell Kavanagh2023-02-061-0/+4
|
* hwdb: ieee1394-unit-function: add MOTU 896 mk3 HybridTakashi Sakamoto2023-02-061-0/+7
| | | | | | This commit adds hwdb entry for MOTU 896 mk3 Hybrid. Reference: https://lore.kernel.org/alsa-devel/63DF98FE.2060604@gmx.de/
* ci: Fix Development Freeze AutomationJan Macku2023-02-032-6/+88
| | | | | | | | | | | | | | | | | | | | Due to the limitation of `GITHUB_TOKEN` when running workflows from forks, it's required to split the `development_freeze` workflow in two. * First workflow will run on the `pull_request` trigger and save the PR number in the artifact. This workflow is running with read-only permissions on `GITHUB_TOKEN`. * Second workflow will get triggered on `workflow_run`. It will be run directly in the `systemd/systemd` context and can get permission to be able to create comments on PR. GITHUB_TOKEN limitations: * https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token GitHub Security Labs Article - How to correctly and safely overcome GITHUB_TOKEN limitations: * https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
* man: correct path for systemd-pcrphaseSimon Brand2023-02-031-1/+1
|
* NEWS: fix typoYu Watanabe2023-02-021-2/+2
|
* update NEWSv253-rc2Lennart Poettering2023-02-021-11/+92
|
* Merge pull request #26302 from bluca/rc2Luca Boccassi2023-02-029-1780/+2277
|\ | | | | Update hwdb for rc2