summaryrefslogtreecommitdiffstats
path: root/docs/DESKTOP_ENVIRONMENTS.md (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-10-23test: rename the global service override file for coverage runsFrantisek Sumsal1-1/+1
Otherwise we break TEST-15-DROPIN, since it uses /usr/lib/systemd/system/service.d/override.conf in some of its sub-tests.
2021-10-23README: fix CentOS CI badgeFrantisek Sumsal1-1/+1
2021-10-23test: disable ProtectHome= when collecting coverage as wellFrantisek Sumsal2-5/+11
Depending on the location of the original build dir, either ProtectHome= or ProtectSystem= may get in the way when creating the gcov metadata files. Follow-up to: * 02d7e73013a92c5580023e4e548d19adbc254dbe * 6c9efba67715cd1ced170ac46c04d47934ad276a
2021-10-23efivars: skip writing if variable is already in wanted stateAnssi Hannula1-1/+25
In order to minimize EFI variable NVRAM wear, do not rewrite variables if they are already in the wanted state (i.e. same data and attributes). This allows e.g. performing repeat calls of "bootctl install" (which always rewrites the EFI boot entry) without consuming EFI NVRAM write cycles.
2021-10-23homed: don't drop caches on activationLennart Poettering3-0/+4
We should drop caches if we are configured to do so in all cases where we are done with home dir operations: except if that operation is activation, because in that case we are not destroying anything, but leaving it on. Hence, turn off the flag that reminds us that we should drop caches before exiting, once activation completed fully, Follow-up for 86019efa4416d7b548cab321c15bc22a65463786
2021-10-22nspawn: ignore --suppress-sync=yes when seccomp is disabledYu Watanabe1-0/+4
Follow-up for 4a4654e0241fbeabecb8587fd3520b6b39264b9c. Fixes #21090.
2021-10-22nspawn: bump RLIMIT_NOFILE for nspawn payload similar to how host PID 1 does ↵Lennart Poettering1-0/+9
it for its payload We try to pass containers roughly the same rlimits as the host gets from the kernel. However, this means we'd set the RLIMIT_NOFILE to 4K. Which is quite limiting though, and is something we actually departed from in PID1: since 52d620757817bc0fa7de3ddbe43024544ced7ea0 we raise the limit substantially for all userspace. Given that nspawn is quite often invoked without proper PID1, let's raise the limits for container payloads the same way as we do from the real PID1 to its service payloads.
2021-10-22update TODOLennart Poettering1-0/+6
2021-10-22sd-boot: Add keys to reboot into firmware interfaceJan Janssen3-22/+53
This is useful if the auto-firmware setting has been disabled. The keys used here are based on what the majority of firmware employ in the wild. This also ensures there's a chance for the user to discover this in case they were too slow during POST or simply used the wrong ones.
2021-10-22update TODOLennart Poettering1-0/+8
2021-10-22process-util: move sync() out of freeze()Lennart Poettering2-2/+1
We are using this for creating userns namespaces, and we really shouldn't try to sync there. Moreover the use of free() in shutdown code doesn't need it anyway, since it just sync()ed right before anyway. Only the third user of freeze() we have actually needs the syc(), hence do it there and nowhere else.
2021-10-22namespace-util: introduce userns_acquire() as helper for allocating new ↵Lennart Poettering3-23/+45
unbound userns This returns a namespace fd, and takes a uidmap/gidmap as string. This is split out out mount-util.c's remount_idmap() logic, so that we can allocate a userns independently.
2021-10-22basic: move freeze() from shared/exec-util.h to basic/process-util.hLennart Poettering4-25/+23
That way we can use it in other code from basic/. It fits into both headers equally well or badly, hence let's just move this one function.
2021-10-22homework: split home_unshare_and_mount() in twoLennart Poettering3-5/+18
Previously the call did two things, and the second thing was optional (depending on first arg being NULL). Let's simplify this and just make it two distinct functions, where one calls the other. This should make things a bit more readable, given that we called a function called "…and_mount()" which didn't actually mount... No actual code changes, just some refactoring.
2021-10-22homework: use bit fields where we deal with lots of separate boolean flagsLennart Poettering1-6/+6
No actual code changes, just making a structure a bit shorter.
2021-10-22homework: add macro for "/run/systemd/user-home-mount"Lennart Poettering5-15/+20
We use this work dir a various places, and it's easy to mistype, hence let the compiler detect this for us, and introduce a macro for it. No code changes, just some search/replace.
2021-10-22network: dhcp6pd: fix the default value of subnet IDYu Watanabe1-1/+1
The type of dhcp6_pd_subnet_id is int64_t.
2021-10-22varlink: disconnect varlink link in one more caseLennart Poettering1-3/+4
Previously we'd possibly see POLLHUP on a varlink link, and continue to run epoll on it even though we have nothing to read nor write anymore. Let's fix that, and once we know that there's nothing to write anymore (or we saw a write error already) we'll disconnect after POLLHUP. Fixes: #20062
2021-10-22test-fd-util: add test case for fd_reopen()Lennart Poettering1-0/+96
2021-10-22fd-util: tweak error handling in fd_reopen()Lennart Poettering1-3/+6
If we know that /proc/ works, then ENOENT when reopening an fd means the fd didn't exist. Let's return the correct error code for that, i.e. EBADF.
2021-10-22fd-util: when re-opening a directory with fd_reopen() go via openat(…, ↵Lennart Poettering1-0/+10
".", …) This adds a tiny shortcut to fd_reopen(): if we are about to reopen the fd via O_DIRECTORY then we know it#s a directory and we might as well reopen it via opening "." using the fd as "at fd" in openat(). This has the benefit that we don't need /proc/self/fd/ around for this special case: fewer sources of errors.
2021-10-22test-networkd-address: fix clock typeLennart Poettering1-2/+2
The clock to use internally is clock_boottime_or_monotonic(), but the test used CLOCK_MONOTONIC. After one system suspend the test thus likely starts to fail.
2021-10-22sd-boot: Be more precise about secure boot modesJan Janssen10-17/+111
Fixes: #11559
2021-10-22network: dhcp6pd: check link state earlier before assigning prefixes to ↵Yu Watanabe1-5/+5
downstream Also, narrow the acceptable range of the states.
2021-10-22network: dhcp6pd: also call dhcp6_pd_prepare() and dhcp6_pd_finalize() for ↵Yu Watanabe1-8/+14
upstream interface As now the subnet prefix may be assigned to the upstream interface.
2021-10-21hwdb: Allow USB autosuspend for MS Surface Pro (2017) Type CoverJonas Dreßler1-0/+8
The Surface Type Covers are known to support USB autosuspend just fine (and it's also enabled by default on Windows), so enable it in hwdb.
2021-10-21network: dhcp6pd: not necessary to drop routes when Assign=yesYu Watanabe1-30/+34
2021-10-21test: make the coverage check safer for non-compiled buildsFrantisek Sumsal1-1/+9
2021-10-21test: collect the coverage _before_ unmounting the rootfsFrantisek Sumsal1-1/+1
d'oh!
2021-10-21test: loosen sandbox restrictions for integration tests as wellFrantisek Sumsal1-4/+12
Otherwise we miss quite a lot of coverage (mainly from logind, hostnamed, networkd, and possibly others), since they can't write their reports with `ProtectSystem=strict`.
2021-10-21test: loosen certain sandbox restrictions when collecting coverageFrantisek Sumsal1-0/+7
With `ProtectSystem=strict` gcov is unable to write the *.gcda files with collected coverage. Let's add a yet another switch to make such restriction less strict to make gcov happy. This addresses following errors: ``` ... systemd-networkd[272469]: profiling:/systemd-meson-build/src/shared/libsystemd-shared-249.a.p/binfmt-util.c.gcda:Cannot open systemd-networkd[272469]: profiling:/systemd-meson-build/src/shared/libsystemd-shared-249.a.p/base-filesystem.c.gcda:Cannot open systemd-networkd[272469]: profiling:/systemd-meson-build/src/shared/libsystemd-shared-249.a.p/barrier.c.gcda:Cannot open systemd-networkd[272469]: profiling:/systemd-meson-build/src/shared/libsystemd-shared-249.a.p/ask-password-api.c.gcda:Cannot open systemd-networkd[272469]: profiling:/systemd-meson-build/src/shared/libsystemd-shared-249.a.p/apparmor-util.c.gcda:Cannot open systemd-networkd[272469]: profiling:/systemd-meson-build/src/shared/libsystemd-shared-249.a.p/acpi-fpdt.c.gcda:Cannot open ... ```
2021-10-21test: wait a bit for the given PID to die if it's still aliveFrantisek Sumsal1-0/+10
When playing around with the coverage-enabled build I kept hitting an issue where dnsmasq failed to start because the previous instance was still shutting down. This should, hopefully, help to mitigate that.
2021-10-21icmp6: shorten code a bitYu Watanabe1-7/+6
2021-10-21dhcp: shorten BPF code a bitYu Watanabe1-10/+6
- replace `A = k` and `X = A` with `X = k`, - replace `A ^= X` and `A == 0` with `A == X`. - use UINT32_MAX when accept a packet
2021-10-21dhcp: rebreak function argumentsYu Watanabe1-8/+23
2021-10-21dhcp: fix assertionsYu Watanabe1-2/+5
2021-10-21dhcp: shorten code a bitYu Watanabe1-9/+3
2021-10-21lldp: shorten code a bitYu Watanabe1-16/+5
2021-10-21arp-util: shorten BPF code a bitYu Watanabe2-23/+16
- replace `A = k` and `X = A` with `X = k`, - replace `A ^= X` and `A == 0` with `A == X`. - use UINT32_MAX when accept a packet
2021-10-21network: address: use usec_t for handling lifetimeYu Watanabe8-95/+152
This drops stuct ifa_cacheinfo from Address, and store lifetime with usec_t. Why? Now, all requests of address configurations are once stored in the request queue, and will be processed when it is ready. So, the timestamp value passed to the kernel must be evaluated on configure. This also fixes the following two issues. - Time values in struct ifa_cacheinfo are stored in uint32_t. So, the validity check of the address configured by NDisc may fail on long running systems. - If a system uses DHCPv6PD, when an interface may appear or be reconfigured later, then the lifetime value may be inappropriate. We need to adjust the lifetime with the current time and the timestamp of the lease.
2021-10-21network: ndisc: rename valid_until -> lifetime_usecYu Watanabe2-22/+30
2021-10-21network: ndisc: add missing lifetime checkYu Watanabe1-4/+7
2021-10-21network: route: rename lifetime -> lifetime_usecYu Watanabe4-32/+37
2021-10-21network: drop unnecessary header inclusionYu Watanabe1-1/+0
2021-10-21CI: disable code coverage in GH ActionLuca Boccassi2-15/+0
It is now ran on the nightly CentOS build, so that it can cover integration tests too, and not just unit tests. It's nightly as it considerably increases the integration test runtime, so it's not appropriate for all PRs.
2021-10-20test: don't install test-network-generator-conversion.sh w/o networkdFrantisek Sumsal1-3/+6
otherwise TEST-02 will fail: ``` === Failed test log === --- test-network-generator-conversion.sh begin --- + [[ -n '' ]] + [[ -x /usr/lib/systemd/systemd-network-generator ]] + [[ -x /lib/systemd/systemd-network-generator ]] + exit 1 --- test-network-generator-conversion.sh end --- ``` Before: ``` $ meson build -Dnetworkd=false -Dinstall-tests=true $ ninja -C build $ DESTDIR=$PWD/test-install ninja -C build install $ find test-install/ -name test-network-generator-conversion.sh test-install/usr/lib/systemd/tests/test-network-generator-conversion.sh ``` After: ``` $ find test-install/ -name test-network-generator-conversion.sh <no output> ```
2021-10-20test: collect coverage in a couple more codepathsFrantisek Sumsal2-0/+3
Otherwise we'd miss coverage from TEST-{02,24,61}, since they don't go through the "standard" `check_result_common` hook. Follow-up to 7bf20e48bd7d641a39a14a7feb749b7e8b0fc0f6.
2021-10-20zsh-completion: nspawn: add --suppress-sync optionYu Watanabe1-0/+1
Follow-up for 4a4654e0241fbeabecb8587fd3520b6b39264b9c.
2021-10-20Typos found by codespellDimitri Papadopoulos26-34/+34
2021-10-20efi: check input parameterZbigniew Jędrzejewski-Szmek1-0/+3
clang complained about an unused variable. We cast the buffer to struct boot_params, so let's check that it's at least this long.