summaryrefslogtreecommitdiffstats
path: root/src/fundamental (follow)
Commit message (Collapse)AuthorAgeFilesLines
* sha256: external headers should be included with <>Lennart Poettering2022-12-081-1/+1
|
* stub: handle random seed like sd-boot doesJason A. Donenfeld2022-11-231-0/+1
| | | | | | | | | sd-stub has an opportunity to handle the seed the same way sd-boot does, which would have benefits for UKIs when sd-boot is not in use. This commit wires that up. It refactors the XBOOTLDR partition discovery to also find the ESP partition, so that it access the random seed there.
* macro: fix indentationYu Watanabe2022-10-251-1/+1
|
* macro: Simply case macros for IN_SETJan Janssen2022-10-251-22/+21
| | | | | | | | | The CASE param would normally provide the operation for the compiler to do in this macro magic. But in this case CASE_F_1 was hardcoding the operation, making the parameter moot. This just removes the somewhat pointless parameter instead of fixing the one case. These macros are used for IN_SET case labels only and not named generically anyways.
* macro: Use more correct type in IN_SETJan Janssen2022-10-251-5/+3
| | | | | | | | | | | | This will now catch mistakes like this: struct s { int i:2; } s = { 1 }; assert_se(IN_SET(s.i, ULLONG_MAX)); > warning: implicit conversion from 'unsigned long long' to > 'typeof (+s.i)' (aka 'int') changes value from 18446744073709551615 > to -1 [-Wconstant-conversion]
* macro-fundamental: allow to nest ASSERT_PTRDavid Tardon2022-09-141-12/+7
| | | | | | | | | E.g., int job_frobnicate(Job *j) { Unit *u = ASSERT_PTR(ASSERT_PTR(j)->unit); ... }
* tree-wide: use ASSERT_PTR moreDavid Tardon2022-09-131-2/+1
|
* stub: add new special PE sections ".pcrsig" and ".pcrpkey" in unified kernelsLennart Poettering2022-09-092-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These aren't wired up yet to do anything useful. For now we just define them. This sections are supposed to carry a signature for expected measurements on PCR 11 if this kernel is booted, in the JSON format "systemd-measure sign" generates, and the public key used for the signature. The idea is to embedd the signature and the public key in unified kernels and making them available to userspace, so that userspace can easily access them and enroll (for which the public key is needed) or unlock (for which the PCR signature is needed) LUKS2 volumes and credentials that are bound to the currently used kernel version stream. Why put these files in PE sections rather than just into simple files in the initrd or into the host fs? The signature cannot be in the initrd, since it is after all covering the initrd, and thus the initrd as input for the calculation cannot carry the result of the calculation. Putting the signature onto the root fs sucks too, since we typically want to unlock the root fs with it, hence it would be inaccessible for it's primary purpose then. The public key could be in the initrd or in the root fs, there's no technical restriction for that. However, I still think it's a good idea to put it in a PE section as well, because this means the piece of code that attaches the signature can also attach the public key easily in one step, which is nice since it allows separating the roles of the kernel/initrd/root fs builder, and the role of the signer, and the former doesn't have to have knowledge about what the latter is going to add to the image. Note that the signature section is excluded from the TPM measurements sd-stub does about its resource sections, since – as mentioned – it's the expected output of the signing operation whose input are the measurements, hence it cannot also be input to them. The public key section is included in the measurements however.
* sha256: add sha256_direct()/SHA256_DIRECT() helpersLennart Poettering2022-08-192-0/+11
|
* sha256: change digest buffer type to uint8_t[]Lennart Poettering2022-08-192-3/+3
| | | | | This way we can specify a size with "static". All users use uint8_t already, hence this comes at no price.
* macro: use ISPOWEROF2() at various placesLennart Poettering2022-08-051-11/+2
|
* macro: add macro for checking if integer is power of 2Lennart Poettering2022-08-051-0/+13
|
* boot: add three new boot loader feature flagsLennart Poettering2022-08-021-0/+3
| | | | | | | | | | | | | | | | | Report whether the devicetree + sort-key boot loader spec type #1 fields are supported, and whether the "@saved" pseudo-entry is supported. Strictly speaking, thes features have been added in versions that are already released (250+), so by adding this those version even though they support the features will be considered not supporting them, but that should be OK (the opposite would be a problem though, i.e. if we'd assume a boot loader had a feature it actually does not). These three features are features relevant to userspace, as it allows userspace to tweak/genereate BLS entries or set EFI vars correctly. Other features (i.e. that have no impliciations to userspace) are not reported.
* stub: introduce StubFeatures, similar to LoaderFeaturesLennart Poettering2022-08-021-0/+7
| | | | | | | | | | | | | | systemd-boot reports its features via the LoaderFeatures EFI variable. Let's add something similar for stub features, given they have been growing. For starters only define four feature flags. One is a baseline feature we pretty much always supported (see comment in code), two are features added in one of the most recently released systemd version, and the final one, is a feature we added a few commits ago. This is useful for userspace to figure out what is supported and what not.
* boot: move unified kernel PE section definitions into 'fundamental' codeLennart Poettering2022-08-023-0/+30
| | | | | Le's share this code between userspace and uefispace. This is useful later when pre-measuring expected PCRs from userspace.
* boot: split out TPM PCR defines into header file we can share between ↵Lennart Poettering2022-08-022-0/+25
| | | | userspace and kernel space
* test-bus-objects: Test GetManagedObjects interfaces are correctigo958622022-07-251-0/+14
| | | | | | | | | Objects without ObjectManager should not have `org.freedesktop.DBus.ObjectManager` interface. Object with ObjectManager should do. Also added ASSERT_SE_NONNEG and ASSERT_NONNEG macros.
* fundamental: replace __sync with __atomic in ONCE macromatoro2022-07-141-4/+4
| | | | | For this one, we can actually just use __atomic_exchange_n since we don't need the "compare" part of __atomic_compare_exchange_n.
* fundamental: adjust #if conditional for _fallthrough_ for clangThomas Haller2022-07-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | NetworkManager takes systemd sources. It gets compiler warnings related to _fallthrough_. They probably can also affect systemd itself. A) on RHEL-7, gcc 4.8.5-44.el7 we get: ../src/libnm-systemd-shared/src/fundamental/macro-fundamental.h:45:22: error: "__clang__" is not defined [-Werror=undef] #if __GNUC__ >= 7 || __clang__ ^ Presumably gcc older than 7 is supported, so fix this. B) on Ubuntu 18.04, clang 1:6.0-41~exp5~ubuntu1 we get: ../src/libnm-systemd-core/src/libsystemd-network/sd-dhcp6-client.c:746:17: error: declaration does not declare anything [-Werror,-Wmissing-declarations] _fallthrough_; ^ ../src/libnm-systemd-shared/src/fundamental/macro-fundamental.h:46:25: note: expanded from macro '_fallthrough_' # define _fallthrough_ __attribute__((__fallthrough__)) ^ Granted, README comments that clang >= 10 is required. However, parts of systemd build just fine with older clang. It seems unnecessary to break this and the fix helps NetworkManager. Fixes: c0f5d58c9ab7 ('meson: Document why -Wimplicit-fallthrough is not used with clang')
* tree-wide: add global ascii_isdigit() + ascii_isalpha()Lennart Poettering2022-07-052-16/+16
| | | | | | | | We now have a local implementation in string-util-fundamental.c, but it's useful at a lot of other places, hence let's give it a more expressive name and share it across the tree. Follow-up for: 8d9156660d6958c8d63b1d44692968f1b5d33920
* fundamental: Remove types-fundamental.hJan Janssen2022-06-279-83/+30
| | | | | | | | | | | | | This removes the fundamental typedefs in favor of just using standard C types. These are all used internally anyway and also do not do anything special to warrant any redefinition to EFI types. Even for BOOLEAN we can safely use stdbool. The defition from the EFI specification is fully compatible, including making any other values than 0/1 as undefined. The exception is sd_char as those need to be char16_t. The typedef is moved to string-util-fundamental.h instead.
* sha256: Use stdbool and uintptr_tJan Janssen2022-06-242-19/+6
| | | | | | This also syncs the copyright blurb with current glibc sources. The written by line does not appear in upstream, so it should be okay to remove.
* boot: Add xmallocJan Janssen2022-06-091-2/+1
|
* sha256: fix compilation on efi-ia32Zbigniew Jędrzejewski-Szmek2022-06-031-1/+1
| | | | | | | | | | | | | | | | /usr/bin/gcc -c ../src/fundamental/sha256.c -o src/boot/efi/sha256.c.o -Wno-format-signedness -Wno-missing-field-initializers -Wno-unused-parameter -Wdate-time -Wendif-labels -Werror=format=2 -Werror=implicit-function-declaration -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wno-unused-result -fno-stack-protector -fno-strict-aliasing -fpic -fwide-exec-charset=UCS2 -Wall -Wextra -Wsign-compare -nostdlib -std=gnu99 -ffreestanding -fshort-wchar -fvisibility=hidden -isystem /usr/include/efi -isystem /usr/include/efi/ia32 -I /builddir/build/BUILD/systemd-stable-250.7/src/fundamental -DSD_BOOT -DGNU_EFI_USE_MS_ABI -include src/boot/efi/efi_config.h -include version.h -mno-sse -mno-mmx -flto -O2 -flto=auto ../src/fundamental/sha256.c: In function ‘sha256_finish_ctx’: ../src/fundamental/sha256.c:61:25: error: ‘false’ undeclared (first use in this function) 61 | # define UNALIGNED_P(p) false | ^~~~~ ../src/fundamental/sha256.c:136:21: note: in expansion of macro ‘UNALIGNED_P’ 136 | if (UNALIGNED_P(resbuf)) | ^~~~~~~~~~~ ../src/fundamental/sha256.c:32:1: note: ‘false’ is defined in header ‘<stdbool.h>’; did you forget to ‘#include <stdbool.h>’? 31 | #include "sha256.h" +++ |+#include <stdbool.h> 32 | ...
* sha256: use memcpy() when result buffer is unalignedYu Watanabe2022-06-021-19/+20
| | | | Fixes #23578.
* Merge pull request #23531 from yuwata/sd-bus-drop-version-2Yu Watanabe2022-06-011-0/+8
|\ | | | | sd-bus: drop version 2 format support
| * macro: make ALIGN4() and ALIGN8() also return SIZE_MAX on overflowYu Watanabe2022-05-311-0/+8
| | | | | | | | This also drops unused ALIGN4_PTR(), ALIGN8_PTR(), and ALIGN_TO_PTR().
* | boot: Use memcmp/memcpy/memsetJan Janssen2022-05-313-4/+4
| |
* | boot: Use strcmp8/16Jan Janssen2022-05-311-6/+5
| | | | | | | | | | | | This also replaces streq and similar functions for consistency. Note that streq16 is null pointer safe, so streq_ptr can be safely replaced too.
* | boot: Use strlen8/16Jan Janssen2022-05-311-10/+11
|/ | | | | | | The casts in this and the next few commits are curently necessary because CHAR8 is defined as uint8_t in gnu-efi, while char is signed. Once we switch from gnu-efi typedefs to stdint types, the casts will be dropped.
* meson: Document why -Wimplicit-fallthrough is not used with clangJan Janssen2022-05-281-1/+1
| | | | | This changes the macro to ensure proper fallthrough attributes are used with clang in case this option is added in the future.
* macro: Move attribute defintions to macro-fundamentalJan Janssen2022-05-281-9/+28
| | | | This also sorts them.
* Merge pull request #23504 from keszybz/bls-reorderingLuca Boccassi2022-05-271-10/+15
|\ | | | | Refactor the BLS and add a description of version sorts
| * docs/BLS: describe version comparisonsZbigniew Jędrzejewski-Szmek2022-05-251-2/+2
| | | | | | | | Fixes #23346.
| * basic/string-util: tweak strverscmp_improved() for some corner casesZbigniew Jędrzejewski-Szmek2022-05-251-8/+13
| | | | | | | | | | | | | | | | | | | | | | So far we had the rule that '' == '', '0_' == '0', but '_' > ''. This means that the general rule that strings are compared iteratively, and each segment that compares equal can be dropped and the comparison resumes at the following characters wasn't true in such cases. Similarly, '0~' < '0', but after dropping the common segment, '~' > ''. The special handling of empty strings is dropped, and '_' == '' and '~' < ''.
* | basic: add helper function to print </==/>Zbigniew Jędrzejewski-Szmek2022-05-251-0/+4
|/
* Merge pull request #23414 from keszybz/analyze-vercmpZbigniew Jędrzejewski-Szmek2022-05-232-22/+24
|\ | | | | systemd-analyze compare-versions
| * version comparisons: stop using locale-dependent isdigit()Zbigniew Jędrzejewski-Szmek2022-05-191-8/+7
| | | | | | | | | | | | | | | | The docs are not entirely clear what glyphs qualify as digits. The function is supposed to be locale-dependent, but I couldn't get it to return true on any non-ascii digits I tried. But it's better to be safe than sorry, let's use our trivial replacement instead.
| * fundamental: make strverscmp_improved() return -1/0/+1 in all casesZbigniew Jędrzejewski-Szmek2022-05-171-3/+3
| | | | | | | | | | | | | | We would return the result of strcmp(), i.e. some positive/negative value. Now that we want to make this a documented interface for other people to implement, let's make the implementation more contstrained, even if we ourselves don't care about whether the specific values.
| * fundamental/string-util-fundamental: include appropriate headersZbigniew Jędrzejewski-Szmek2022-05-171-3/+3
| | | | | | | | We were using CMP() without pulling the definition in directly.
| * basic: make macro-fundamental.h self-containedZbigniew Jędrzejewski-Szmek2022-05-171-1/+2
| | | | | | | | When !SD_BOOT, it used size_t without including the appropriate header.
| * Clean up the text in description of strverscmp_improved()Zbigniew Jędrzejewski-Szmek2022-05-171-7/+9
| |
* | Do not require a valid version when parsing sd-boot loader entriesVictor Westerhuis2022-05-221-1/+1
| | | | | | | | This fixes #20820
* | fundamental: Move some helpers into string-util-fundamentalJan Janssen2022-05-211-0/+17
| |
* | macro: Use C11 noreturn onlyJan Janssen2022-05-211-8/+0
| | | | | | | | No need to provide a fallback as we compile with gnu11.
* | macro: Use C11 static_assertJan Janssen2022-05-201-9/+3
| | | | | | | | Now that we require C11 everywhere, we can always use static_assert.
* | boot: Build with C11 tooJan Janssen2022-05-201-1/+1
| |
* | Add a "test" that prints the SBAT tableZbigniew Jędrzejewski-Szmek2022-05-171-0/+8
|/ | | | | | | | | The SBAT section was included in a special section in the EFI code, but the contents weren't directly visible in any way. Let's add a "test" that prints them for visual inspection. If there's some external linter for this format, we could hook it up in the future.
* tree-wide: add a space after if, switch, for, and whileYu Watanabe2022-04-011-12/+12
|
* sd-boot: make use of new "sort-key" boot loader spec fieldLennart Poettering2022-03-182-9/+16
|
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-13 08:52:27 +0100