| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| | |
Addresses https://github.com/systemd/systemd/pull/34959#discussion_r1860451777
|
| | |
|
| |
| |
| |
| | |
Follow-up for e2501a851e10f5279862b2bccbdd9184572cce6a
|
| |
| |
| |
| | |
Follow-up for bbec1c87d3bf8d14eeb1ee3b4df973a53cca2e58
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
let's just check the debug invocation boolean, and not recheck the
restart mode again. It's mostly redundant (because the boolean should
not have been become true if the restart mode was not set accordingly).
Moreover, i think we might want to eventually allow a manual way to
enable debug invocation mode, and hence this pointless checking would
become a problem.
Also, we never check the restart mode again in other cases, hence we
shouldn't here either.
|
| |
| |
| |
| | |
to perms
|
|/
|
|
|
|
| |
When registering we condition this on "arg_register". Let's do the same
when unregistering, otherwise we might end up trying to unregister a
machine we never registered.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The bootspec util-lib's handling of global addons didn't previously
match the behavior of sd-stub, and this commit corrects that.
First, bootspec didn't load global addons from the XBOOTLDR dir, but the
stub does. So, bootspec now enumerates addons in XBOOTLDR, not just ESP
Second, the stub only loads resources (including addons) from the
partition that it was found on. Thus, we must keep track of which
partition the global addons come from, and which partition each boot
entry comes from. In other words: global addons found on the ESP will
NOT apply to UKIs found in XBOOTLDR, and bootspec now reflects that.
|
| |
| |
| |
| | |
Follow-up for 59b3df9
|
| |
| |
| |
| |
| | |
This would previously leak memory: the array was deleted but contents
inside of the array were not
|
| |
| |
| |
| |
| |
| |
| |
| | |
A previous commit accidentally reversed the measurement order of the
confext initrds and sysext initrds via a minor typo. This commit fixes
the typo and restores the original measurement order
Follow-up: ac32323
|
|\ \
| |/
|/| |
Fixes #35176
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
When determining the poll events to wait for we need to take the queue
of pending messages that carry fds into account. Otherwise we might end
up not waking up if such an fd-carrying message is enqueued
asynchronously (i.e. not from a dispatch callback).
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
key-data might be NULL. Fixes crash:
0 0x0000559c62120530 in attach_luks_or_plain_or_bitlk (cd=0x559c6b192830, name=0x7ffd57981dc4 "root", token_type=TOKEN_FIDO2, key_file=0x0, key_data=0x0, passwords=0x0, flags=524296, until=0)
at ../src/cryptsetup/cryptsetup.c:2234
pass_volume_key = false
r = 1469577760
__func__ = '\000' <repeats 29 times>
1 0x0000559c6212279c in run (argc=6, argv=0x7ffd5797fe98) at ../src/cryptsetup/cryptsetup.c:2597
discovered_key_data = {iov_base = 0x0, iov_len = 0}
key_data = 0x0
token_type = TOKEN_FIDO2
destroy_key_file = 0x0
flags = 524296
until = 0
passphrase_type = PASSPHRASE_NONE
volume = 0x7ffd57981dc4 "root"
source = 0x7ffd57981dc9 "/dev/disk/by-uuid/8372fb39-9ba4-461a-a618-07dcaae66280"
status = CRYPT_INACTIVE
tries = 0
key_file = 0x0
config = 0x7ffd57981e05 "luks,discard,fido2-device=auto,x-initrd.attach"
use_cached_passphrase = true
try_discover_key = true
discovered_key_fn = 0x7ffd5797fa70 "root.key"
passwords = 0x0
cd = 0x559c6b192830
verb = 0x7ffd57981dbd "attach"
r = 0
__func__ = "\000\000\000"
2 0x0000559c621231e6 in main (argc=6, argv=0x7ffd5797fe98) at ../src/cryptsetup/cryptsetup.c:2674
r = 32553
__func__ = "\000\000\000\000"
Follow-up for 53b6c99018f918a5d2c9000ac5fe3a2440115ea7
|
| |
| |
| |
| |
| | |
The signature was changed to 'sit' in sysupdated during review, but updatectl
kept using 'sbt'
|
|\ \
| | |
| | | |
Fixes #35329.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This partially reverts the commit 405be62f05d76f1845f347737b5972158c79dd3e
"tree-wide: refuse enumerated device with ID_PROCESSING=1".
Otherwise, when systemd-udev-trigger.service is (re)started just before
daemon-reexec, which can be easily happen on systemd package update, then
udev database files for many devices may have ID_PROCESSING=1 property,
thus devices may not be enumerated on daemon-reexec. That causes many
units especially mount units being deactivated after daemon-reexec.
Fixes #35329.
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a more comprehensive fix compared to #35273. Also adds a minimal
test only.
Based on Luca's #35273 but generalizes the code a bit.
In v258 we really should get rid of the old heuristics around userns and
cgroupns detection, but given we are late in the v257 cycle this keeps
them in.
|
| | | |
|
| | |
| | |
| | |
| | | |
running_in_cgroupns() too
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The indoe number of root pid namespace is hardcoded in the kernel to
0xEFFFFFFC since 3.8, so check the inode number of our pid namespace
if all else fails. If it's not 0xEFFFFFFC then we are in a pid
namespace, hence a container environment.
Fixes https://github.com/systemd/systemd/issues/35249
[Reworked by Lennart, to make use of namespace_is_init()]
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
This allows reusing them for integration-test-wrapper.py as well.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
already dead
Similar to c5ecf0949460dd0bf3211db128a385ce6375252e, but for io event source.
Fixes #35322.
|
| | |
| | |
| | |
| | | |
'dtbauto' command line was missing from the help string. Add it.
|
| | |
| | |
| | |
| | | |
It's the PID that is wrong, not the UID/GID, be precise.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The wrong error code was logged.
But actually given that userns_mkdir() is fine with existing dirs, let's
drop the redundant conditionalization.
Follow-up for: a1fcaa1549d86098d0ba75254b6afc96c786b3b6
|
| | |
| | |
| | |
| | |
| | | |
No functional change, just refactoring, as anyway all errors will be
ignored by the caller.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
is_idmapping_supported() (#35313)
Follow-up for edae62120f13b24d51812d1d7c0ab24acb420305.
Fixes #35311.
|
| | | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
is_idmapping_supported()
Follow-up for edae62120f13b24d51812d1d7c0ab24acb420305.
Fixes #35311.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Otherwise, the ioctl() may fail with EBUSY.
Follow-up for b4b66b26620bfaf5818c95d5cffafd85207694e7.
Hopefully fixes #35243.
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Those are historical names, but there is nothing wrong with them. The files on
/ (/fastboot, /forcefsck, and /forcequotacheck) are problematic because they
require a modification of the root file system. But the commandline params work
fine. They have the obvious advantage compared to our "modern" option that they
are much easier to type without looking up the spelling in the docs. Undeprecate
them to avoid unnecessary churn.
|
| | |
|
|\ \
| | |
| | | |
Fixes: #35294
|
| | |
| | |
| | |
| | | |
Follow-up for: ad5de3222f7
|
| | |
| | |
| | |
| | | |
Fixes: #35294
|
| | |
| | |
| | |
| | |
| | | |
Outside of userns the concept makes no sense, there cannot be users
mapped from further outside.
|
| | | |
|
|\ \ \
| |/ /
|/| | |
|
| |/
| |
| |
| |
| | |
In the --help text we really should use the official spelling, just like
in the man page.
|
|/
|
|
|
|
|
|
| |
Without this change, the fd is closed twice on failure.
Fixes a bug introduced by dff9808a628c31b7ecb1f1aba8fdc3be06ce8372.
Fixes #35288.
|
|
|
|
|
|
| |
CID#1565824
Follow-up for f6793bbcf0e3f0a6daa77add96183b88d5ec2117
|
|
|
|
| |
Follow-up for 2b07a3211ba8b1b81d6cebb9650d5cb24554b08a.
|