| Commit message (Collapse) | Author | Files | Lines |
|---|
|
Files found with:
for f in *; do \
l=`tr -d '[^(]' < $f | wc -c`; \
r=`tr -d '[^)]' < $f | wc -c`; \
if [ $l -ne $r ]; then \
echo $f $l $r; \
fi; \
done
|
|
The fuzzer test case has a giant line with ";;;;;;;;;;;..." which is turned into
a strv of empty strings. Unfortunately, when pushing each string, strv_push() needs
to walk the whole array, which leads to quadratic behaviour. So let's use
greedy_allocation here and also keep location in the string to avoid iterating.
build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812 51.10s user 0.01s system 99% cpu 51.295 total
↓
build/fuzz-xdg-desktop test/fuzz/fuzz-xdg-desktop/oss-fuzz-22812 0.07s user 0.01s system 96% cpu 0.083 total
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22812.
Other minor changes:
- say "was already defined" instead of "defined multiple times" to make it
clear that we're ignoring this second definition, and not all definitions
of the key
- unescaping needs to be done also for the last entry
|
|
For a user "from the kernel" might be rather unclear.
|
|
|
|
We generally don't include stuff that is not used. This can be
easily ressurected if ever needed.
Fixes CID#1430210.
|
|
|
|
[thaller@redhat.com: original patch by Yuri, extracted from [1]]
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/565
|
|
|
|
|
