From b2e0caf882d846805b4cb947fe4098c4b822e7ba Mon Sep 17 00:00:00 2001 From: Jan Macku Date: Tue, 27 Feb 2024 14:26:52 +0100 Subject: ci(lint): exclude zsh completion from ShellCheck zsh is not supported by ShellCheck --- .github/workflows/differential-shellcheck.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to '.github') diff --git a/.github/workflows/differential-shellcheck.yml b/.github/workflows/differential-shellcheck.yml index b04aabb14a..6072c526d8 100644 --- a/.github/workflows/differential-shellcheck.yml +++ b/.github/workflows/differential-shellcheck.yml @@ -31,5 +31,8 @@ jobs: uses: redhat-plumbers-in-action/differential-shellcheck@91e2582e40236f831458392d905578d680baa138 with: # exclude all `.in` files because they may contain unsupported syntax, and they have to be preprocessed first - exclude-path: '**/*.in' + # exclude zsh completion files, zsh is not supported by ShellCheck + exclude-path: | + '**/*.in' + 'shell-completion/zsh/*' token: ${{ secrets.GITHUB_TOKEN }} -- cgit v1.2.3 From 464b03d23c49119587df65989837ede9ff15734b Mon Sep 17 00:00:00 2001 From: Jan Macku Date: Tue, 27 Feb 2024 15:33:36 +0100 Subject: ci(lint): temporarily disable ShellCheck for bash-completion This commit should be reverted once bash completion is in better shape when it comes to ShellCheck. --- .github/workflows/differential-shellcheck.yml | 2 ++ 1 file changed, 2 insertions(+) (limited to '.github') diff --git a/.github/workflows/differential-shellcheck.yml b/.github/workflows/differential-shellcheck.yml index 6072c526d8..89811edb95 100644 --- a/.github/workflows/differential-shellcheck.yml +++ b/.github/workflows/differential-shellcheck.yml @@ -31,8 +31,10 @@ jobs: uses: redhat-plumbers-in-action/differential-shellcheck@91e2582e40236f831458392d905578d680baa138 with: # exclude all `.in` files because they may contain unsupported syntax, and they have to be preprocessed first + # TEMPORARY: exclude bash completion files, they would generate too many defects in Code scanning dashboard (600+) # exclude zsh completion files, zsh is not supported by ShellCheck exclude-path: | '**/*.in' + 'shell-completion/bash/*' 'shell-completion/zsh/*' token: ${{ secrets.GITHUB_TOKEN }} -- cgit v1.2.3