From 2f82562bad423d1190912a4b209647dfac966db2 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 13 Oct 2021 12:38:37 +0200 Subject: alloc-util: add strdupa_safe() + strndupa_safe() and use it everywhere Let's define two helpers strdupa_safe() + strndupa_safe() which do the same as their non-safe counterparts, except that they abort if called with allocations larger than ALLOCA_MAX. This should ensure that all our alloca() based allocations are subject to this limit. afaics glibc offers three alloca() based APIs: alloca() itself, strndupa() + strdupa(). With this we have now replacements for all of them, that take the limit into account. --- src/backlight/backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/backlight') diff --git a/src/backlight/backlight.c b/src/backlight/backlight.c index 6fcf584667..fd92135fc7 100644 --- a/src/backlight/backlight.c +++ b/src/backlight/backlight.c @@ -387,7 +387,7 @@ static int run(int argc, char *argv[]) { if (!sysname) return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Requires a subsystem and sysname pair specifying a backlight device."); - ss = strndupa(argv[2], sysname - argv[2]); + ss = strndupa_safe(argv[2], sysname - argv[2]); sysname++; -- cgit v1.2.3