From ffb7406ba9c12a58dd944574ab565f39aabb0dfa Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Tue, 5 Apr 2022 10:51:21 +0200 Subject: tests: add a smoke test for --version option in binaries This is very similar to (and directly based on) the test for --help. I think it's nice to do this: the test is very quick, but it'll catch cases where we forgot to hook up the option, or forgot to exit after printing --version, and it'll also increase our test coverage a bit. --- tools/check-help.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'tools/check-help.sh') diff --git a/tools/check-help.sh b/tools/check-help.sh index 76ac292675..19ec941469 100755 --- a/tools/check-help.sh +++ b/tools/check-help.sh @@ -3,8 +3,8 @@ set -eu set -o pipefail -# Note: `grep ... >/dev/null` instead of just `grep -q` is used intentionally -# here, since `grep -q` exits on the first match causing SIGPIPE being +# Note: 'grep ... >/dev/null' instead of just 'grep -q' is used intentionally +# here, since 'grep -q' exits on the first match causing SIGPIPE being # sent to the sender. BINARY="${1:?}" @@ -24,11 +24,11 @@ fi # --help prints something. Also catches case where args are ignored. if ! "$BINARY" --help | grep . >/dev/null; then - echo "$(basename "$BINARY") --help output is empty." + echo "$(basename "$BINARY") --help output is empty" exit 2 fi -# no --help output to stdout +# no --help output to stderr if "$BINARY" --help 2>&1 1>/dev/null | grep .; then echo "$(basename "$BINARY") --help prints to stderr" exit 3 -- cgit v1.2.3