diff options
| author | kaorihinata <kaori.hinata@gmail.com> | 2020-01-09 22:47:57 +0100 |
|---|---|---|
| committer | Sam Doran <sdoran@redhat.com> | 2020-01-09 22:47:57 +0100 |
| commit | 3ca4580cb4e2a24597c6c5108bf76bbcd48069f8 (patch) | |
| tree | a3a25b9b8ea1eb9d77faecdd8ad2802024d9baef /changelogs | |
| parent | win_user_right - docs to show how to remove all (#66315) (diff) | |
| download | ansible-3ca4580cb4e2a24597c6c5108bf76bbcd48069f8.tar.xz ansible-3ca4580cb4e2a24597c6c5108bf76bbcd48069f8.zip | |
Allow no_log=False to silence the no_log warnings for module parameters (#64733)
As AnsibleModule._log_invocation is currently implemented, any parameter
with a name that matches PASSWORD_MATCH triggers the no_log warning as a
precaution against parameters that may contain sensitive data, but have not
been marked as sensitive by the module author.
This patch would allow module authors to explicitly mark the aforementioned
parameters as not sensitive thereby bypassing an erroneous warning message,
while still catching parameters which have not been marked at all by the
author.
Adds tests for various no_log states including True, False, and None (as
extracted by AnsibleModule._log_invocation) when applied to an argument with
a name that matches PASSWORD_MATCH.
Fixes: #49465 #64656
Diffstat (limited to 'changelogs')
| -rw-r--r-- | changelogs/fragments/64733-make-no_log-false-override-no_log-warnings.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/changelogs/fragments/64733-make-no_log-false-override-no_log-warnings.yml b/changelogs/fragments/64733-make-no_log-false-override-no_log-warnings.yml new file mode 100644 index 0000000000..bcf0567d58 --- /dev/null +++ b/changelogs/fragments/64733-make-no_log-false-override-no_log-warnings.yml @@ -0,0 +1,2 @@ +bugfixes: + - "make ``no_log=False`` on a module option silence the ``no_log`` warning (https://github.com/ansible/ansible/issues/49465 https://github.com/ansible/ansible/issues/64656)" |