Deprecate tests used as filters (#32361)

* Warn on tests used as filters

* Update docs, add aliases for tests that fit more gramatically with test syntax

* Fix rst formatting

* Add successful filter, alias of success

* Remove renamed_deprecation, it was overkill

* Make directory alias for is_dir

* Update tests to use proper jinja test syntax

* Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax

* Add conversion script, porting guide updates, and changelog updates

* Update newly added uses of tests as filters

* No underscore variable

* Convert recent tests as filter changes to win_stat

* Fix some changes related to rebasing a few integration tests

* Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name

* Add test for tests_as_filters_warning

* Update tests as filters in newly added/modified tests

* Address recent changes to several integration tests

* Address recent changes in cs_vpc

2 files changed, 15 insertions, 15 deletions

diff --git a/test/integration/targets/win_dsc/tasks/destructive.yml b/test/integration/targets/win_dsc/tasks/destructive.yml
index f455f9dbd6..9616608839 100644
--- a/test/integration/targets/win_dsc/tasks/destructive.yml
+++ b/test/integration/targets/win_dsc/tasks/destructive.yml
@@ -56,7 +56,7 @@
 - name: assert results of create an IIS website (check mode)
   assert:
     that:
-    - win_dsc_iis_check|changed
+    - win_dsc_iis_check is changed
     - win_dsc_iis_check_result.exists == False
 
 - name: create an IIS website with auth and binding info
@@ -92,7 +92,7 @@
 - name: assert results of create an IIS website
   assert:
     that:
-    - win_dsc_iis|changed
+    - win_dsc_iis is changed
     - win_dsc_iis_result.exists == True
     - win_dsc_iis_result.auth.anonymous == True
     - win_dsc_iis_result.auth.basic == False
@@ -132,4 +132,4 @@
 - name: assert results of create an IIS website (idempotent)
   assert:
     that:
-    - not win_dsc_iis_again|changed
+    - win_dsc_iis_again is not changed
diff --git a/test/integration/targets/win_dsc/tasks/tests.yml b/test/integration/targets/win_dsc/tasks/tests.yml
index 9866001796..b724fb37e7 100644
--- a/test/integration/targets/win_dsc/tasks/tests.yml
+++ b/test/integration/targets/win_dsc/tasks/tests.yml
@@ -42,7 +42,7 @@
 - name: assert result of add Windows feature (check mode)
   assert:
     that:
-    - win_dsc_add_feature_check|changed
+    - win_dsc_add_feature_check is changed
     - win_dsc_add_feature_result_check.stdout == "False\r\n"
 
 - name: add Windows feature
@@ -59,7 +59,7 @@
 - name: assert result of add Windows feature
   assert:
     that:
-    - win_dsc_add_feature|changed
+    - win_dsc_add_feature is changed
     - win_dsc_add_feature_result.stdout == "True\r\n"
 
 - name: add Windows feature (idempotent)
@@ -72,7 +72,7 @@
 - name: assert result of add Windows feature (idempotent)
   assert:
     that:
-    - not win_dsc_add_feature_again|changed
+    - win_dsc_add_feature_again is not changed
 
 - name: remove Windows feature (check mode)
   win_dsc:
@@ -89,7 +89,7 @@
 - name: assert result of remove Windows feature (check mode)
   assert:
     that:
-    - win_dsc_remove_feature_check|changed
+    - win_dsc_remove_feature_check is changed
     - win_dsc_remove_feature_result_check.stdout == "True\r\n"
 
 - name: remove Windows feature
@@ -106,7 +106,7 @@
 - name: assert result of remove Windows feature
   assert:
     that:
-    - win_dsc_remove_feature|changed
+    - win_dsc_remove_feature is changed
     - win_dsc_remove_feature_result.stdout == "False\r\n"
 
 - name: remove Windows feature (idempotent)
@@ -119,7 +119,7 @@
 - name: assert result of remove Windows feature (idempotent)
   assert:
     that:
-    - not win_dsc_remove_feature_again|changed
+    - win_dsc_remove_feature_again is not changed
 
 - name: ensure test folder doesn't exist before test
   win_file:
@@ -147,7 +147,7 @@
 - name: assert results of create test file (check mode)
   assert:
     that:
-    - win_dsc_create_file_check|changed
+    - win_dsc_create_file_check is changed
     - win_dsc_create_file_result_check.stat.exists == False
 
 - name: create test file
@@ -170,7 +170,7 @@
 - name: assert results of create test file
   assert:
     that:
-    - win_dsc_create_file|changed
+    - win_dsc_create_file is changed
     - win_dsc_create_file_result.stat.exists == True
     - win_dsc_create_file_result.stat.isdir == False
     - win_dsc_create_file_result.stat.ishidden == True
@@ -189,7 +189,7 @@
 - name: assert results of create test file (idempotent)
   assert:
     that:
-    - not win_dsc_create_file_again|changed
+    - win_dsc_create_file_again is not changed
 
 - name: get SID of current ansible user
   win_shell: (New-Object System.Security.Principal.NTAccount("{{ansible_user}}")).Translate([System.Security.Principal.SecurityIdentifier]).ToString()
@@ -216,7 +216,7 @@
 - name: assert results of run DSC process as another user
   assert:
     that:
-    - win_dsc_runas|changed
+    - win_dsc_runas is changed
     - win_dsc_runas_result.content|b64decode == win_dsc_actual_sid.stdout
 
 - name: create custom DSC resource folder
@@ -305,7 +305,7 @@
 - name: assert result of custom DSC resource
   assert:
     that:
-    - test_dsc_custom|changed
+    - test_dsc_custom is changed
     - test_dsc_custom_output.content|b64decode|strip_newline == test_dsc_custom_expected|strip_newline
 
 - name: run custom DSC resource with version
@@ -326,5 +326,5 @@
 - name: assert result of custom DSC resource with version
   assert:
     that:
-    - test_dsc_custom|changed
+    - test_dsc_custom is changed
     - test_dsc_custom_output_version.content|b64decode|strip_newline == test_dsc_custom_expected_version|strip_newline