diff options
author | Matt Clay <matt@mystile.com> | 2022-04-27 23:07:15 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-27 23:07:15 +0200 |
commit | 5c2d830dea986a8c7bd8c286b86bdce326cd7eb1 (patch) | |
tree | a4c4e26f1f9e27d75c0e383ef15bb175dd3b3879 /test/lib/ansible_test/_internal/pypi_proxy.py | |
parent | Update guide_vultr.rst (#77665) (diff) | |
download | ansible-5c2d830dea986a8c7bd8c286b86bdce326cd7eb1.tar.xz ansible-5c2d830dea986a8c7bd8c286b86bdce326cd7eb1.zip |
ansible-test - Fix subprocess management. (#77641)
* Run code-smell sanity tests in UTF-8 Mode.
* Update subprocess use in sanity test programs.
* Use raw_command instead of run_command with always=True set.
* Add more capture=True usage.
* Don't expose stdin to subprocesses.
* Capture more output. Warn on retry.
* Add more captures.
* Capture coverage cli output.
* Capture windows and network host checks.
* Be explicit about interactive usage.
* Use a shell for non-captured, non-interactive subprocesses.
* Add integration test to assert no TTY.
* Add unit test to assert no TTY.
* Require blocking stdin/stdout/stderr.
* Use subprocess.run in ansible-core sanity tests.
* Remove unused arg.
* Be explicit with subprocess.run check=False.
* Add changelog.
* Use a Python subprocess instead of a shell.
* Use InternalError instead of Exception.
* Require capture argument.
* Check for invalid raw_command arguments.
* Removed pointless communicate=True usage.
* Relocate stdout w/o capture check.
* Use threads instead of a subprocess for IO.
Diffstat (limited to 'test/lib/ansible_test/_internal/pypi_proxy.py')
-rw-r--r-- | test/lib/ansible_test/_internal/pypi_proxy.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/lib/ansible_test/_internal/pypi_proxy.py b/test/lib/ansible_test/_internal/pypi_proxy.py index 51974d261a..f0d778157e 100644 --- a/test/lib/ansible_test/_internal/pypi_proxy.py +++ b/test/lib/ansible_test/_internal/pypi_proxy.py @@ -126,7 +126,8 @@ def configure_target_pypi_proxy(args, profile, pypi_endpoint, pypi_hostname): # force = 'yes' if profile.config.is_managed else 'no' - run_playbook(args, inventory_path, 'pypi_proxy_prepare.yml', dict(pypi_endpoint=pypi_endpoint, pypi_hostname=pypi_hostname, force=force), capture=True) + run_playbook(args, inventory_path, 'pypi_proxy_prepare.yml', capture=True, variables=dict( + pypi_endpoint=pypi_endpoint, pypi_hostname=pypi_hostname, force=force)) atexit.register(cleanup_pypi_proxy) |