summaryrefslogtreecommitdiffstats
path: root/modules/cache
diff options
context:
space:
mode:
authorWilliam A. Rowe Jr <wrowe@apache.org>2001-07-24 22:38:01 +0200
committerWilliam A. Rowe Jr <wrowe@apache.org>2001-07-24 22:38:01 +0200
commit7b2c62a74e85f8ce3b1931452cac2db556651046 (patch)
tree95aca006687973b000fa5624eb4c220981139e2e /modules/cache
parent It's a nit, but since I'm searching for "win32" it ought to be there :) (diff)
downloadapache2-7b2c62a74e85f8ce3b1931452cac2db556651046.tar.xz
apache2-7b2c62a74e85f8ce3b1931452cac2db556651046.zip
Changes to respect the new apr bucket and brigade length types (either
apr_size_t for bucket lengths, or apr_off_t for aggregate brigade lengths.) git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@89683 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'modules/cache')
-rw-r--r--modules/cache/mod_file_cache.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/modules/cache/mod_file_cache.c b/modules/cache/mod_file_cache.c
index d29d472027..a07d25ca57 100644
--- a/modules/cache/mod_file_cache.c
+++ b/modules/cache/mod_file_cache.c
@@ -222,7 +222,10 @@ static void cache_the_file(cmd_parms *cmd, const char *filename, int mmap)
#if APR_HAS_MMAP
if (mmap) {
- /* MMAPFile directive. MMAP'ing the file */
+ /* MMAPFile directive. MMAP'ing the file
+ * XXX: APR_HAS_LARGE_FILES issue; need to reject this request if
+ * size is greater than MAX(apr_size_t) (perhaps greater than 1M?).
+ */
if ((rc = apr_mmap_create(&new_file->mm, fd, 0, new_file->finfo.size,
APR_MMAP_READ, cmd->pool)) != APR_SUCCESS) {
apr_file_close(fd);