diff options
author | Stefan Fritsch <sf@apache.org> | 2011-12-18 18:52:59 +0100 |
---|---|---|
committer | Stefan Fritsch <sf@apache.org> | 2011-12-18 18:52:59 +0100 |
commit | 76f782e188d21d329d242cf3660315e95a68043b (patch) | |
tree | 99d3eb019f81282d5b6b93337349973467262b4b /modules/metadata/mod_usertrack.c | |
parent | Avoid segfault if url->hostname is NULL and filter->hostname is "*" or ".". (diff) | |
download | apache2-76f782e188d21d329d242cf3660315e95a68043b.tar.xz apache2-76f782e188d21d329d242cf3660315e95a68043b.zip |
Various code cleanup to avoid compiler, cppcheck, or clang warnings:
modules/debugging/mod_firehose.c: Make some internal functions static
(to do: logs_cleanup() is unused)
modules/filters/mod_charset_lite.c: Remove dead assignments
modules/filters/mod_include.c: likewise
modules/metadata/mod_usertrack.c: likewise
modules/proxy/mod_proxy_ftp.c: likewise
modules/ssl/ssl_engine_pphrase.c: likewise
modules/proxy/mod_proxy_balancer.c: likewise;
Remove NULL check that can never happen
modules/proxy/proxy_util.c: Axe NULL-check that can never happen and if it
would, it would just mask another bug
os/unix/unixd.c: likewise
modules/http/http_filters.c: Remove sub-condition that is always true
modules/lua/mod_lua.c: Add default cases to switch statements
modules/generators/mod_autoindex.c: Unsigned value can never be < 0
server/util_expr_eval.c: Fix compiler warnings with VC and on OS2
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1220493 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'modules/metadata/mod_usertrack.c')
-rw-r--r-- | modules/metadata/mod_usertrack.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/modules/metadata/mod_usertrack.c b/modules/metadata/mod_usertrack.c index 390adb99e4..61752b7d5b 100644 --- a/modules/metadata/mod_usertrack.c +++ b/modules/metadata/mod_usertrack.c @@ -326,7 +326,6 @@ static const char *set_cookie_exp(cmd_parms *parms, void *dummy, if (!word[0]) return "bad expires code, missing <type>"; - factor = 0; if (!strncasecmp(word, "years", 1)) factor = 60 * 60 * 24 * 365; else if (!strncasecmp(word, "months", 2)) |