summaryrefslogtreecommitdiffstats
path: root/server
diff options
context:
space:
mode:
authorJeff Trawick <trawick@apache.org>2013-10-23 13:59:35 +0200
committerJeff Trawick <trawick@apache.org>2013-10-23 13:59:35 +0200
commita8fbe8c2f05127ca4c8aa45f07cbeee6f40af9ca (patch)
tree27323571f3ffa760485f55d2b769a98c9c23466e /server
parentrotatelogs: Remove last constant length error buffer. (diff)
downloadapache2-a8fbe8c2f05127ca4c8aa45f07cbeee6f40af9ca.tar.xz
apache2-a8fbe8c2f05127ca4c8aa45f07cbeee6f40af9ca.zip
don't ignore some apr_procattr failures (clang scan-build)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1534995 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'server')
-rw-r--r--server/log.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/server/log.c b/server/log.c
index ca5450a26c..a62867e06f 100644
--- a/server/log.c
+++ b/server/log.c
@@ -276,8 +276,10 @@ static int log_child(apr_pool_t *p, const char *progname,
rc = apr_procattr_child_err_set(procattr, errfile, NULL);
}
- rc = apr_proc_create(procnew, args[0], (const char * const *)args,
- NULL, procattr, p);
+ if (rc == APR_SUCCESS) {
+ rc = apr_proc_create(procnew, args[0], (const char * const *)args,
+ NULL, procattr, p);
+ }
if (rc == APR_SUCCESS) {
apr_pool_note_subprocess(p, procnew, APR_KILL_AFTER_TIMEOUT);