summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Worley <sworley@cumulusnetworks.com>2019-08-02 17:12:33 +0200
committerStephen Worley <sworley@cumulusnetworks.com>2019-08-02 17:15:10 +0200
commit00a7f422c346f8cb0a79c5b9a4dd119ca122292c (patch)
tree4a7de41ea965c597f17b0e9ea2517bc17a3643b3
parentMerge pull request #4766 from donaldsharp/redist_small_fix (diff)
downloadfrr-00a7f422c346f8cb0a79c5b9a4dd119ca122292c.tar.xz
frr-00a7f422c346f8cb0a79c5b9a4dd119ca122292c.zip
lib: Remove double log mutex unlock
Coverity report caught this log mutex being unlocked twice. Removing the extra one before the goto statement. Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
-rw-r--r--lib/log.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/log.c b/lib/log.c
index 48ee0f6ad..8e4d2bc60 100644
--- a/lib/log.c
+++ b/lib/log.c
@@ -387,10 +387,8 @@ void vzlog(int priority, const char *format, va_list args)
/* If it doesn't match on a filter, do nothing with the debug log */
if ((priority == LOG_DEBUG) && zlog_filter_count
- && vzlog_filter(zl, &tsctl, proto_str, priority, msg)) {
- pthread_mutex_unlock(&loglock);
+ && vzlog_filter(zl, &tsctl, proto_str, priority, msg))
goto out;
- }
/* call external hook */
hook_call(zebra_ext_log, priority, format, args);