diff options
| author | Christian Franke <chris@opensourcerouting.org> | 2017-08-04 15:44:45 +0200 |
|---|---|---|
| committer | Christian Franke <chris@opensourcerouting.org> | 2017-08-04 15:51:39 +0200 |
| commit | 8955008f72949cc5f61f6b7eeefc16e60ece18bc (patch) | |
| tree | 6c17f590e4467004b06698063172096f662ef04b | |
| parent | Merge pull request #909 from opensourcerouting/isis-perf (diff) | |
| download | frr-8955008f72949cc5f61f6b7eeefc16e60ece18bc.tar.xz frr-8955008f72949cc5f61f6b7eeefc16e60ece18bc.zip | |
isisd: don't validate dict integrity for regular builds
This method is intended to be only used for debugging as per the author
and profiling shows we are spending a lot of cycles on it. Remove it for
regular builds by guarding it with a define.
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
| -rw-r--r-- | isisd/dict.c | 6 | ||||
| -rw-r--r-- | isisd/isisd.h | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/isisd/dict.c b/isisd/dict.c index f09a8152a..2ea86d1b6 100644 --- a/isisd/dict.c +++ b/isisd/dict.c @@ -174,6 +174,7 @@ static int verify_bintree(dict_t *dict) * subtree is not red-black. */ +#ifdef EXTREME_DICT_DEBUG static unsigned int verify_redblack(dnode_t *nil, dnode_t *root) { unsigned height_left, height_right; @@ -198,6 +199,7 @@ static unsigned int verify_redblack(dnode_t *nil, dnode_t *root) } return 1; } +#endif /* * Compute the actual count of nodes by traversing the tree and @@ -205,6 +207,7 @@ static unsigned int verify_redblack(dnode_t *nil, dnode_t *root) * detect a mismatch. */ +#ifdef EXTREME_DICT_DEBUG static dictcount_t verify_node_count(dnode_t *nil, dnode_t *root) { if (root == nil) @@ -213,6 +216,7 @@ static dictcount_t verify_node_count(dnode_t *nil, dnode_t *root) return 1 + verify_node_count(nil, root->left) + verify_node_count(nil, root->right); } +#endif /* * Verify that the tree contains the given node. This is done by @@ -369,6 +373,7 @@ static void dict_clear(dict_t *dict) int dict_verify(dict_t *dict) { +#ifdef EXTREME_DICT_DEBUG dnode_t *nil = dict_nil(dict), *root = dict_root(dict); /* check that the sentinel node and root node are black */ @@ -389,6 +394,7 @@ int dict_verify(dict_t *dict) return 0; if (verify_node_count(nil, root) != dict_count(dict)) return 0; +#endif return 1; } diff --git a/isisd/isisd.h b/isisd/isisd.h index 1aacea881..da02854f5 100644 --- a/isisd/isisd.h +++ b/isisd/isisd.h @@ -37,7 +37,7 @@ /* uncomment if you are a developer in bug hunt */ /* #define EXTREME_DEBUG */ -/* #define EXTREME_TLV_DEBUG */ +/* #define EXTREME_DICT_DEBUG */ struct isis { u_long process_id; |