diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2020-03-11 14:03:17 +0100 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2020-03-11 14:03:17 +0100 |
| commit | 6cd8093d3207e86d318953c3ebd4b9120078a742 (patch) | |
| tree | 724e51495400799b28dfa2f08780fe11b03ec803 /ldpd/hello.c | |
| parent | Merge pull request #5962 from donaldsharp/whichafisafi (diff) | |
| download | frr-6cd8093d3207e86d318953c3ebd4b9120078a742.tar.xz frr-6cd8093d3207e86d318953c3ebd4b9120078a742.zip | |
ldpd: During code inspection we are mixing data sizes
As I understand it ldpd was originally developed as a standalone
daemon for *BSD land. Then ported to FRR. FRR uses ifindex_t
as the base type for the ifindex. Mixing `unsigned short` and
`int` and `unsigned int` is going to lead to fun somewhere
along the way. Especially when we get to run on a system
with ifindex churn( I'm looking at you docker ).
Attempt to convert all of ldpd to think of the ifindex as a
`ifindex_t`.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Diffstat (limited to 'ldpd/hello.c')
| -rw-r--r-- | ldpd/hello.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldpd/hello.c b/ldpd/hello.c index d17e80008..a8d6e58cd 100644 --- a/ldpd/hello.c +++ b/ldpd/hello.c @@ -169,7 +169,7 @@ recv_hello(struct in_addr lsr_id, struct ldp_msg *msg, int af, int tlvs_rcvd; int ds_tlv; union ldpd_addr trans_addr; - uint32_t scope_id = 0; + ifindex_t scope_id = 0; uint32_t conf_seqnum; uint16_t trans_pref; int r; |