diff options
| author | Daniel Walton <dwalton@cumulusnetworks.com> | 2016-09-30 02:16:31 +0200 |
|---|---|---|
| committer | Daniel Walton <dwalton@cumulusnetworks.com> | 2016-09-30 02:16:31 +0200 |
| commit | 58749582a9a2c5930d907d88a3ad0d0c5c24f627 (patch) | |
| tree | ca4b5aed981645901812b40478bb0573e0034230 /lib/filter.c | |
| parent | isisd: scrub argc CHECK ME's, refactor general (diff) | |
| download | frr-58749582a9a2c5930d907d88a3ad0d0c5c24f627.tar.xz frr-58749582a9a2c5930d907d88a3ad0d0c5c24f627.zip | |
all: scrubbed some argc CHECK MEs
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Diffstat (limited to 'lib/filter.c')
| -rw-r--r-- | lib/filter.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/lib/filter.c b/lib/filter.c index fd80b2a63..501b28f2d 100644 --- a/lib/filter.c +++ b/lib/filter.c @@ -1480,8 +1480,8 @@ DEFUN (access_list_remark, "Access list entry comment\n" "Comment up to 100 characters\n") { - /* CHECK ME argc referenced below */ int idx_acl = 1; + int idx_remark = 3; struct access_list *access; access = access_list_get (AFI_IP, argv[idx_acl]->arg); @@ -1491,7 +1491,7 @@ DEFUN (access_list_remark, XFREE (MTYPE_TMP, access->remark); access->remark = NULL; } - access->remark = argv_concat(argv, argc, 1); + access->remark = argv_concat(argv, argc, idx_remark); return CMD_SUCCESS; } @@ -1526,7 +1526,6 @@ DEFUN (no_access_list_remark_comment, "Access list entry comment\n" "Comment up to 100 characters\n") { - /* CHECK ME argc referenced below */ return no_access_list_remark (self, vty, argc, argv); } @@ -1675,8 +1674,8 @@ DEFUN (ipv6_access_list_remark, "Access list entry comment\n" "Comment up to 100 characters\n") { - /* CHECK ME argc referenced below */ int idx_word = 2; + int idx_line = 4; struct access_list *access; access = access_list_get (AFI_IP6, argv[idx_word]->arg); @@ -1686,7 +1685,7 @@ DEFUN (ipv6_access_list_remark, XFREE (MTYPE_TMP, access->remark); access->remark = NULL; } - access->remark = argv_concat(argv, argc, 1); + access->remark = argv_concat(argv, argc, idx_line); return CMD_SUCCESS; } @@ -1715,7 +1714,6 @@ DEFUN (no_ipv6_access_list_remark_comment, "Access list entry comment\n" "Comment up to 100 characters\n") { - /* CHECK ME argc referenced below */ return no_ipv6_access_list_remark (self, vty, argc, argv); } |