diff options
| author | Donald Sharp <sharpd@cumulusnetworks.com> | 2015-05-20 03:04:07 +0200 |
|---|---|---|
| committer | Donald Sharp <sharpd@cumulusnetworks.com> | 2015-05-20 03:04:07 +0200 |
| commit | 2c19a6ec62c6ed4450d237a467734fd24455a983 (patch) | |
| tree | ae5661345b3cb23515421323b34aac05a022b95e /ospfd/ospf_lsa.c | |
| parent | Show enabled debugs in the running configuration (diff) | |
| download | frr-2c19a6ec62c6ed4450d237a467734fd24455a983.tar.xz frr-2c19a6ec62c6ed4450d237a467734fd24455a983.zip | |
Changing router-id inline isnt handled correctly in the current implementation.
At the minimum, the OSPF_LSA_SELF logic isnt foolproof, and it may hit assert
in ospf_refresh_unregister_lsa on a router-id change.
Once OSPF has created and flooded LSAs, its not a good idea to change
router-id inline. Tying it to restart has at least two benefits:
- Implementation can remain sane by not having to re-adjust neighbors and LSAs,
based on the new router-id.
- Works as a deterrent for the user to not meddle with the router-id unless
really needed.
Diffstat (limited to 'ospfd/ospf_lsa.c')
| -rw-r--r-- | ospfd/ospf_lsa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c index f988468e3..ebdb390ab 100644 --- a/ospfd/ospf_lsa.c +++ b/ospfd/ospf_lsa.c @@ -3389,7 +3389,7 @@ ospf_lsa_flush_self_originated (struct ospf_neighbor *nbr, self->data->type, inet_ntoa (self->data->id)); } #else /* ORIGINAL_CODING */ -static int +int ospf_lsa_flush_schedule (struct ospf *ospf, struct ospf_lsa *lsa) { if (lsa == NULL || !IS_LSA_SELF (lsa)) |