summaryrefslogtreecommitdiffstats
path: root/ldpd (follow)
Commit message (Collapse)AuthorAgeFilesLines
* ldpd: free previous config if it wasn't appliedDavid Lamparter2024-10-161-0/+2
| | | | | | | | If a create-config command is received, but the config is never applied, the config will be leaked on the next create-config command. This should theoretically never happen, but let's fix it anyway. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* ldpd: fix wrong gtsm countanlan_cs2024-06-151-0/+12
| | | | | | | | | | | | | | | | In linux networking stack, the received mpls packets will be processed by the host *twice*, one as mpls packet, the other as ip packet, so its ttl decreased 1. So, we need release the `IP_MINTTL` value if gtsm is enabled, it is for the mpls packets of neighbor session caused by the command: `label local advertise explicit-null`. This change makes the gtsm mechanism a bit deviation. Fix PR #8313 Signed-off-by: anlan_cs <vic.lan@pica8.com>
* *: Modify agentx to be allowed to be calledDonald Sharp2024-05-101-0/+2
| | | | | | | | | | | If you had a situation where an operator turned on ospfd with snmp but not ospf6d and agentx was configured then you get into a situation where ospf6d would complain that the config for agentx did not exist. Let's modify the code to allow this situation to happen. Fixes: #15896 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* ldpd: use zlog recirculation for subprocessesDavid Lamparter2024-03-107-182/+72
| | | | | | | | | This way, full functionality of `zlog_*` is available. Having `fatal()` be wrappers around `assertf()` also means we get backtraces, which is not the case for a plain `exit(1)`. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: create a single registry of daemons' default port valuesMark Stapp2024-02-011-1/+0
| | | | | | | | Create a single registry of default port values that daemons are using. Most of these are vty ports, but there are some others for features like ospfapi and zebra FPM. Signed-off-by: Mark Stapp <mjs@labn.net>
* *: fix `frr_daemon_info` indentationDavid Lamparter2024-01-271-0/+2
| | | | | | | | | | clang-format doesn't understand FRR_DAEMON_INFO is a long macro where laying out items semantically makes sense. (Also use only one `FRR_DAEMON_INFO(` in isisd so editors don't get confused with the mismatching `( ( )`. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* build: nuke `LDPD_SOCKET`David Lamparter2024-01-272-22/+11
| | | | | | This just unnecessarily complicates things by involving autoconf. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* lib: zebra.h is not using signal.hDonald Sharp2024-01-091-0/+1
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* *: zebra.h should not have fcntl.hDonald Sharp2024-01-092-0/+3
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* *: remove sys/stat.h from zebra.hDonald Sharp2024-01-091-0/+1
| | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* Merge pull request #14867 from opensourcerouting/zclient-options-cleanupDonald Sharp2023-11-251-5/+1
|\ | | | | *: clean up `zclient` options
| * *: add `zclient_options_sync`David Lamparter2023-11-231-5/+1
| | | | | | | | | | | | | | | | ... and use it instead of fiddling with the `.synchronous` field. (Make it const while at it.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | *: convert `struct interface->connected` to DLISTDavid Lamparter2023-11-221-5/+3
|/ | | | | | | | | | | | | | | | | Replace `struct list *` with `DLIST(if_connected, ...)`. NB: while converting this, I found multiple places using connected prefixes assuming they were IPv4 without checking: - vrrpd/vrrp.c: vrrp_socket() - zebra/irdp_interface.c: irdp_get_prefix(), irdp_if_start(), irdp_advert_off() (these fixes are really hard to split off into separate commits as that would require going back and reapplying the change but with the old list handling) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* *: Let's use the native IFNAMSIZ instead of INTERFACE_NAMSIZDonald Sharp2023-11-211-11/+11
| | | | | | | | INTERFACE_NAMSIZ is just a redefine of IFNAMSIZ and IFNAMSIZ is the standard for interface name length on all platforms that FRR currently compiles on. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* lib: convert if_zapi_callbacks into actual hooksDavid Lamparter2023-11-031-1/+4
| | | | | | | | | ...so that multiple functions can be subscribed. The create/destroy hooks are renamed to real/unreal because that's what they *actually* signal. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* ldpd: Clarify error situation for different problemsDonald Sharp2023-10-131-1/+3
| | | | | | | | Clarify the fatal error message recorded when an error situation happens. Disambiguating the default case from the TLV_TYPE_DYNAMIC_CAP case. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* build: add -Wimplicit-fallthroughIgor Ryzhov2023-10-123-15/+6
| | | | | | | | | | Also: - replace all /* fallthrough */ comments with portable fallthrough; pseudo keyword to accomodate both gcc and clang - add missing break; statements as required by older versions of gcc - cleanup some code to remove unnecessary fallthrough Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
* ldpd: Stop and free synchronous Zebra client on destroyDonatas Abraitis2023-06-272-1/+8
| | | | Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
* ldpd: changes for code maintainabilitysri-mohan12023-06-145-34/+17
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-06-061-41/+32
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-06-051-51/+40
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-06-052-37/+20
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-06-011-39/+33
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-05-231-54/+49
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-05-091-42/+27
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-05-083-44/+29
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-05-071-137/+99
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-05-061-39/+20
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* ldpd: changes for code maintainabilitysri-mohan12023-05-051-40/+30
| | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* Merge pull request #13113 from sri-mohan1/sri-mohan-ldpDonatas Abraitis2023-03-281-22/+15
|\ | | | | ldpd: changes for code maintainability
| * ldpd: changes for code maintainabilitysri-mohan12023-03-271-22/+15
| | | | | | | | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* | *: Convert event.h to frrevent.hDonald Sharp2023-03-241-1/+1
| | | | | | | | | | | | | | We should probably prevent any type of namespace collision with something else. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Convert `struct event_master` to `struct event_loop`Donald Sharp2023-03-244-8/+8
| | | | | | | | | | | | Let's find a better name for it. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Convert THREAD_XXX macros to EVENT_XXX macrosDonald Sharp2023-03-2410-73/+73
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Convert struct thread_master to struct event_master and it's ilkDonald Sharp2023-03-244-9/+8
| | | | | | | | | | | | | | Convert the `struct thread_master` to `struct event_master` across the code base. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Convert thread_timer_remain_XXX to event_timer_remain_XXXDonald Sharp2023-03-243-3/+3
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Convert thread_fetch and thread_call to event_fetch and event_callDonald Sharp2023-03-242-4/+4
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Convert thread_add_XXX functions to event_add_XXXDonald Sharp2023-03-2410-60/+58
| | | | | | | | Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Rename `struct thread` to `struct event`Donald Sharp2023-03-2413-87/+87
| | | | | | | | | | | | | | | | | | Effectively a massive search and replace of `struct thread` to `struct event`. Using the term `thread` gives people the thought that this event system is a pthread when it is not Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | *: Rename thread.[ch] to event.[ch]Donald Sharp2023-03-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | This is a first in a series of commits, whose goal is to rename the thread system in FRR to an event system. There is a continual problem where people are confusing `struct thread` with a true pthread. In reality, our entire thread.c is an event system. In this commit rename the thread.[ch] files to event.[ch]. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
* | Merge pull request #12920 from sri-mohan1/sri-mohan-ldpmobash-rasool2023-03-012-12/+12
|\| | | | | ldpd: changes for code maintainability
| * ldpd: changes for code maintainabilitysri-mohan12023-03-012-12/+12
| | | | | | | | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* | Merge pull request #12863 from sri-mohan1/sri-mohan-ldpDonald Sharp2023-02-221-127/+103
|\| | | | | ldpd: changes for code maintainability
| * ldpd: changes for code maintainabilitysri-mohan12023-02-221-127/+103
| | | | | | | | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* | Merge pull request #12851 from sri-mohan1/sri-mohan-ldpRuss White2023-02-211-53/+97
|\| | | | | ldpd: changes for code maintainability
| * ldpd: changes for code maintainabilitysri-mohan12023-02-201-53/+97
| | | | | | | | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* | Merge pull request #12845 from sri-mohan1/sri-mohan-ldpDonatas Abraitis2023-02-191-10/+15
|\| | | | | ldpd: changes for code maintainability
| * ldpd: changes for code maintainabilitysri-mohan12023-02-191-10/+15
| | | | | | | | | | | | these changes are for improving the code maintainability and readability Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>
* | *: auto-convert to SPDX License IDsDavid Lamparter2023-02-0938-483/+38
| | | | | | | | | | | | Done with a combination of regex'ing and banging my head against a wall. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
* | Merge pull request #12707 from donaldsharp/missed_enumsDonatas Abraitis2023-02-074-21/+19
|\ \ | |/ |/| Missed enums
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 12:54:49 +0100