diff options
| author | Michal Nowikowski <godfryd@isc.org> | 2019-02-19 21:53:52 +0100 |
|---|---|---|
| committer | Michal Nowikowski <godfryd@isc.org> | 2019-02-19 21:54:31 +0100 |
| commit | ed91e4c5d78b2085d01f6ba67d9712e212e0832f (patch) | |
| tree | 80acbc9889850d9c020febdd838c4a428d12d058 | |
| parent | perfdhcp avalache: improvements after review (diff) | |
| download | kea-ed91e4c5d78b2085d01f6ba67d9712e212e0832f.tar.xz kea-ed91e4c5d78b2085d01f6ba67d9712e212e0832f.zip | |
perfdhcp avalanche: added todo comments
| -rw-r--r-- | src/bin/perfdhcp/avalanche_scen.cc | 4 | ||||
| -rw-r--r-- | src/bin/perfdhcp/tests/basic_scen_unittest.cc | 4 | ||||
| -rw-r--r-- | src/bin/perfdhcp/tests/command_options_unittest.cc | 2 |
3 files changed, 7 insertions, 3 deletions
diff --git a/src/bin/perfdhcp/avalanche_scen.cc b/src/bin/perfdhcp/avalanche_scen.cc index 8db1098f9f..0681ea1133 100644 --- a/src/bin/perfdhcp/avalanche_scen.cc +++ b/src/bin/perfdhcp/avalanche_scen.cc @@ -125,6 +125,10 @@ AvalancheScen::run() { usleep(100); now = microsec_clock::universal_time(); + // Wait for 200ms between subsequent check for resending. + // This time taken based on experiments. For times 10-30ms whole scenario + // time significantly grows. The same for times >200ms. The optimal times + // are between 50-200ms. \todo more research is needed. if (now - prev_cycle_time > milliseconds(200)) { // check if 0.2s elapsed prev_cycle_time = now; int still_left_cnt = 0; diff --git a/src/bin/perfdhcp/tests/basic_scen_unittest.cc b/src/bin/perfdhcp/tests/basic_scen_unittest.cc index a3f2f553f1..24b743c791 100644 --- a/src/bin/perfdhcp/tests/basic_scen_unittest.cc +++ b/src/bin/perfdhcp/tests/basic_scen_unittest.cc @@ -243,7 +243,7 @@ TEST_F(BasicScenTest, Packet4ExchangeMaxDrop10Proc) { // Use templates for this test. processCmdLine(opt, "perfdhcp -l fake -r 100 -R 20 -n 100" " -D 10% -L 10547 -g single" - // TODO: seems to be broken as it crashes building pkt + // \todo seems to be broken as it crashes building pkt // " -T " + getFullPath("discover-example.hex") // + " -T " + getFullPath("request4-example.hex") " 127.0.0.1"); @@ -289,7 +289,7 @@ TEST_F(BasicScenTest, Packet6ExchangeMaxDrop3Pkt) { // The maximum number of dropped packets is 3 (because of -D 3). processCmdLine(opt, "perfdhcp -l fake" " -6 -r 100 -n 100 -R 20 -D 3 -L 10547" - // TODO: seems to be broken as it crashes building pkt + // \todo seems to be broken as it crashes building pkt // " -T " + getFullPath("solicit-example.hex") // + " -T " + getFullPath("request6-example.hex") " ::1"); diff --git a/src/bin/perfdhcp/tests/command_options_unittest.cc b/src/bin/perfdhcp/tests/command_options_unittest.cc index 3b0bc79b04..ef54afdaf7 100644 --- a/src/bin/perfdhcp/tests/command_options_unittest.cc +++ b/src/bin/perfdhcp/tests/command_options_unittest.cc @@ -597,7 +597,7 @@ TEST_F(CommandOptionsTest, Offsets) { EXPECT_THROW(process(opt, "perfdhcp -6 -I -4 -l ethx all"), isc::InvalidParameter); - // TODO - other negative cases + // \todo other negative cases } TEST_F(CommandOptionsTest, LocalPort) { |