perfdhcp avalache: improvements after review

- simplified differentiating for IP version and exchange types
- added more comments
- fixed unittest for receiver by mocking socket
- added option for building perfdhcp by hammer
- added workaround for compiler bug that cannot handle enum class
  as a key to std::unordered_map
- hidden warnings from boost by changing compiler flag
  from -I<boost-path> to -isystem <boost-path>
- removed unused options_ field from StatsMgr class

1 files changed, 16 insertions, 0 deletions

diff --git a/src/bin/perfdhcp/perf_socket.h b/src/bin/perfdhcp/perf_socket.h
index 83f8b971b8..bdb18ee7bb 100644
--- a/src/bin/perfdhcp/perf_socket.h
+++ b/src/bin/perfdhcp/perf_socket.h
@@ -17,11 +17,18 @@
 namespace isc {
 namespace perfdhcp {
 
+/// \brief Socket wrapper structure.
+///
+/// This is a base class that is inherited by PerfSocket
+/// and unit tests derived that. This way it allows mocking
+/// out socket operations and avoid using real network
+/// interfaces.
 class BasePerfSocket : public dhcp::SocketInfo {
 public:
     /// Interface index.
     uint16_t ifindex_;
 
+    /// \brief Default constructor of BasePerfSocket.
     BasePerfSocket() :
         SocketInfo(asiolink::IOAddress("127.0.0.1"), 0, 0),
         ifindex_(0) {}
@@ -29,10 +36,19 @@ public:
     /// \brief Destructor of the socket wrapper class.
     virtual ~BasePerfSocket() = default;
 
+    /// \brief See description of this method in PerfSocket class below.
     virtual dhcp::Pkt4Ptr receive4(uint32_t timeout_sec, uint32_t timeout_usec) = 0;
+
+    /// \brief See description of this method in PerfSocket class below.
     virtual dhcp::Pkt6Ptr receive6(uint32_t timeout_sec, uint32_t timeout_usec) = 0;
+
+    /// \brief See description of this method in PerfSocket class below.
     virtual bool send(const dhcp::Pkt4Ptr& pkt) = 0;
+
+    /// \brief See description of this method in PerfSocket class below.
     virtual bool send(const dhcp::Pkt6Ptr& pkt) = 0;
+
+    /// \brief See description of this method in PerfSocket class below.
     virtual dhcp::IfacePtr getIface() = 0;
 };