summaryrefslogtreecommitdiffstats
path: root/src/lib/cc
diff options
context:
space:
mode:
authorShane Kerr <shane@isc.org>2013-01-14 16:51:21 +0100
committerShane Kerr <shane@isc.org>2013-01-14 16:55:38 +0100
commitf65147ed98354cb39e52568a6ff1f7f98ad885ff (patch)
treebe804614abdef16791148522e7a44a228997a860 /src/lib/cc
parent[2571] a small optimization: avoid calling strlen() every time in loop (diff)
downloadkea-f65147ed98354cb39e52568a6ff1f7f98ad885ff.tar.xz
kea-f65147ed98354cb39e52568a6ff1f7f98ad885ff.zip
[2571] Explain unit test for character 255.
Diffstat (limited to 'src/lib/cc')
-rw-r--r--src/lib/cc/tests/data_unittests.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/lib/cc/tests/data_unittests.cc b/src/lib/cc/tests/data_unittests.cc
index 9c41a31a30..9f015d2915 100644
--- a/src/lib/cc/tests/data_unittests.cc
+++ b/src/lib/cc/tests/data_unittests.cc
@@ -91,6 +91,9 @@ TEST(Element, from_and_to_json) {
sv.push_back("-1");
sv.push_back("-1.234");
sv.push_back("-123.456");
+ // We should confirm that our string handling is 8-bit clean.
+ // At one point we were using char-length data and comparing to EOF,
+ // which means that character '\xFF' would not parse properly.
sv.push_back("\"\xFF\"");
BOOST_FOREACH(const std::string& s, sv) {