diff options
| author | Nicolas Saenz Julienne <nsaenz@kernel.org> | 2021-08-31 14:58:42 +0200 |
|---|---|---|
| committer | Florian Fainelli <f.fainelli@gmail.com> | 2021-10-12 18:14:16 +0200 |
| commit | 13dbc954b3c9a9de0ad5b7279e8d3b708d31068b (patch) | |
| tree | 7172017bf47ade8a02cbe97bd61aa53884a25dbf | |
| parent | ARM: dts: bcm2711-rpi-4-b: fix sd_io_1v8_reg regulator states (diff) | |
| download | linux-13dbc954b3c9a9de0ad5b7279e8d3b708d31068b.tar.xz linux-13dbc954b3c9a9de0ad5b7279e8d3b708d31068b.zip | |
ARM: dts: bcm2711-rpi-4-b: Fix pcie0's unit address formatting
dtbs_check currently complains that:
arch/arm/boot/dts/bcm2711-rpi-4-b.dts:220.10-231.4: Warning
(pci_device_reg): /scb/pcie@7d500000/pci@1,0: PCI unit address format
error, expected "0,0"
Unsurprisingly pci@0,0 is the right address, as illustrated by its reg
property:
&pcie0 {
pci@0,0 {
/*
* As defined in the IEEE Std 1275-1994 document,
* reg is a five-cell address encoded as (phys.hi
* phys.mid phys.lo size.hi size.lo). phys.hi
* should contain the device's BDF as 0b00000000
* bbbbbbbb dddddfff 00000000. The other cells
* should be zero.
*/
reg = <0 0 0 0 0>;
};
};
The device is clearly 0. So fix it.
Also add a missing 'device_type = "pci"'.
Fixes: 258f92d2f840 ("ARM: dts: bcm2711: Add reset controller to xHCI node")
Suggested-by: Rob Herring <robh@kernel.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210831125843.1233488-1-nsaenzju@redhat.com
Signed-off-by: Nicolas Saenz Julienne <nsaenz@kernel.org>
| -rw-r--r-- | arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts index abf8298610a7..43cd71574115 100644 --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts @@ -217,7 +217,8 @@ }; &pcie0 { - pci@1,0 { + pci@0,0 { + device_type = "pci"; #address-cells = <3>; #size-cells = <2>; ranges; |