diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2018-11-06 23:45:02 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2018-11-06 23:45:02 +0100 |
| commit | 1bfc204dc0e7a690ab8440e91bb7d1a324320fdc (patch) | |
| tree | b547933d4b8ab37c1e7521e86139c6691ae6b631 | |
| parent | ext4: avoid possible double brelse() in add_new_gdb() on error path (diff) | |
| download | linux-1bfc204dc0e7a690ab8440e91bb7d1a324320fdc.tar.xz linux-1bfc204dc0e7a690ab8440e91bb7d1a324320fdc.zip | |
ext4: remove unneeded brelse call in ext4_xattr_inode_update_ref()
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/xattr.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index f36fc5d5b257..dc1aeab06dba 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1031,10 +1031,8 @@ static int ext4_xattr_inode_update_ref(handle_t *handle, struct inode *ea_inode, inode_lock(ea_inode); ret = ext4_reserve_inode_write(handle, ea_inode, &iloc); - if (ret) { - iloc.bh = NULL; + if (ret) goto out; - } ref_count = ext4_xattr_inode_get_ref(ea_inode); ref_count += ref_change; @@ -1080,12 +1078,10 @@ static int ext4_xattr_inode_update_ref(handle_t *handle, struct inode *ea_inode, } ret = ext4_mark_iloc_dirty(handle, ea_inode, &iloc); - iloc.bh = NULL; if (ret) ext4_warning_inode(ea_inode, "ext4_mark_iloc_dirty() failed ret=%d", ret); out: - brelse(iloc.bh); inode_unlock(ea_inode); return ret; } |