diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-21 15:33:59 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-09-23 01:14:32 +0200 |
| commit | 227b9e8708b14a8a26ef67bbbe19b13626df4a35 (patch) | |
| tree | 2ba3ff492d381c9d5bd6d26f3fd3f42afaef250e | |
| parent | rndis_wlan: fix checking for default value (diff) | |
| download | linux-227b9e8708b14a8a26ef67bbbe19b13626df4a35.tar.xz linux-227b9e8708b14a8a26ef67bbbe19b13626df4a35.zip | |
usbnet: remove invalid check
skb->len is always non-negative.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/lan78xx.c | 5 | ||||
| -rw-r--r-- | drivers/net/usb/smsc75xx.c | 5 | ||||
| -rw-r--r-- | drivers/net/usb/smsc95xx.c | 5 |
3 files changed, 0 insertions, 15 deletions
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 6a70a72b565d..d2a5f3f88b13 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2424,11 +2424,6 @@ static int lan78xx_rx(struct lan78xx_net *dev, struct sk_buff *skb) skb_pull(skb, align_count); } - if (unlikely(skb->len < 0)) { - netdev_warn(dev->net, "invalid rx length<0 %d", skb->len); - return 0; - } - return 1; } diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index d9e7892262fa..30033dbe6662 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/drivers/net/usb/smsc75xx.c @@ -2185,11 +2185,6 @@ static int smsc75xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) skb_pull(skb, align_count); } - if (unlikely(skb->len < 0)) { - netdev_warn(dev->net, "invalid rx length<0 %d\n", skb->len); - return 0; - } - return 1; } diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 26423adc35ee..66b3ab9f614e 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -1815,11 +1815,6 @@ static int smsc95xx_rx_fixup(struct usbnet *dev, struct sk_buff *skb) skb_pull(skb, align_count); } - if (unlikely(skb->len < 0)) { - netdev_warn(dev->net, "invalid rx length<0 %d\n", skb->len); - return 0; - } - return 1; } |