diff options
| author | Johan Hovold <johan@kernel.org> | 2021-04-07 12:39:05 +0200 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2021-04-08 09:45:53 +0200 |
| commit | 2ab5836101f8e06877917458aed1e13020a43e43 (patch) | |
| tree | 43964cd664c223cbde2ebccb818092ee8577b721 | |
| parent | USB: serial: f81534: fix TIOCGSERIAL implementation (diff) | |
| download | linux-2ab5836101f8e06877917458aed1e13020a43e43.tar.xz linux-2ab5836101f8e06877917458aed1e13020a43e43.zip | |
USB: serial: ftdi_sio: fix TIOCGSERIAL implementation
TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
serial devices is only useful for setting the close_delay and
closing_wait parameters.
The FTDI driver is the only USB serial driver supporting the deprecated
ASYNC_SPD flags, which are reported back as they should by TIOCGSERIAL,
but the returned parameters did not include the line number.
The close_delay and closing_wait parameters returned by TIOCGSERIAL are
specified in centiseconds. The driver does not yet support changing
these, but let's report back the default values actually used (0.5 and
30 seconds, respectively).
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/ftdi_sio.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index c867592477c9..f8a0911f90ea 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1483,9 +1483,13 @@ static int get_serial_info(struct tty_struct *tty, struct usb_serial_port *port = tty->driver_data; struct ftdi_private *priv = usb_get_serial_port_data(port); + ss->line = port->minor; ss->flags = priv->flags; ss->baud_base = priv->baud_base; ss->custom_divisor = priv->custom_divisor; + ss->close_delay = 50; + ss->closing_wait = 3000; + return 0; } |