diff options
| author | Steve French <stfrench@microsoft.com> | 2022-10-15 03:00:32 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-10-15 17:05:53 +0200 |
| commit | 2bff0659338e58a3a24698a35e7dcb2b62199ba4 (patch) | |
| tree | 1c07a17d31a087e5e1cf535267ad96e4967816b9 | |
| parent | cifs: lease key is uninitialized in smb1 paths (diff) | |
| download | linux-2bff0659338e58a3a24698a35e7dcb2b62199ba4.tar.xz linux-2bff0659338e58a3a24698a35e7dcb2b62199ba4.zip | |
cifs: lease key is uninitialized in two additional functions when smb1
cifs_open and _cifsFileInfo_put also end up with lease_key uninitialized
in smb1 mounts. It is cleaner to set lease key to zero in these
places where leases are not supported (smb1 can not return lease keys
so the field was uninitialized).
Addresses-Coverity: 1514207 ("Uninitialized scalar variable")
Addresses-Coverity: 1514331 ("Uninitialized scalar variable")
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index dcec1690312b..f6ffee514c34 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -489,7 +489,7 @@ void _cifsFileInfo_put(struct cifsFileInfo *cifs_file, struct cifsInodeInfo *cifsi = CIFS_I(inode); struct super_block *sb = inode->i_sb; struct cifs_sb_info *cifs_sb = CIFS_SB(sb); - struct cifs_fid fid; + struct cifs_fid fid = {}; struct cifs_pending_open open; bool oplock_break_cancelled; @@ -571,7 +571,7 @@ int cifs_open(struct inode *inode, struct file *file) void *page; const char *full_path; bool posix_open_ok = false; - struct cifs_fid fid; + struct cifs_fid fid = {}; struct cifs_pending_open open; struct cifs_open_info_data data = {}; |