summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2023-08-08 04:40:30 +0200
committerChandan Babu R <chandan.babu@oracle.com>2023-08-18 10:12:36 +0200
commit2c234a22866e4f322ca578397ad381f02a95001a (patch)
tree29430c6a421b011bf631ff1f7db7614d7a3f73f7
parentMerge tag 'scrub-bmap-fixes-6.6_2023-08-10' of https://git.kernel.org/pub/scm... (diff)
downloadlinux-2c234a22866e4f322ca578397ad381f02a95001a.tar.xz
linux-2c234a22866e4f322ca578397ad381f02a95001a.zip
xfs: fix dqiterate thinko
For some unknown reason, when I converted the incore dquot objects to store the dquot id in host endian order, I removed the increment here. This causes the scan to stop after retrieving the root dquot, which severely limits the usefulness of the quota scrubber. Fix the lost increment, though it won't fix the problem that the quota iterator code filters out zeroed dquot records. Fixes: c51df7334167e ("xfs: stop using q_core.d_id in the quota code") Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
-rw-r--r--fs/xfs/xfs_dquot.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
index 7f071757f278..ac6ba646624d 100644
--- a/fs/xfs/xfs_dquot.c
+++ b/fs/xfs/xfs_dquot.c
@@ -1386,7 +1386,7 @@ xfs_qm_dqiterate(
return error;
error = iter_fn(dq, type, priv);
- id = dq->q_id;
+ id = dq->q_id + 1;
xfs_qm_dqput(dq);
} while (error == 0 && id != 0);