diff options
| author | Stefan Berger <stefanb@linux.ibm.com> | 2022-09-20 15:15:18 +0200 |
|---|---|---|
| committer | Jarkko Sakkinen <jarkko@kernel.org> | 2022-10-04 23:25:56 +0200 |
| commit | 2d869f0b458547386fbcd8cf3004b271b7347b7f (patch) | |
| tree | bf3d7b96f7e427195bc911dab0e226dbf1773be4 | |
| parent | security/keys: Remove inconsistent __user annotation (diff) | |
| download | linux-2d869f0b458547386fbcd8cf3004b271b7347b7f.tar.xz linux-2d869f0b458547386fbcd8cf3004b271b7347b7f.zip | |
selftest: tpm2: Add Client.__del__() to close /dev/tpm* handle
The following output can bee seen when the test is executed:
test_flush_context (tpm2_tests.SpaceTest) ... \
/usr/lib64/python3.6/unittest/case.py:605: ResourceWarning: \
unclosed file <_io.FileIO name='/dev/tpmrm0' mode='rb+' closefd=True>
An instance of Client does not implicitly close /dev/tpm* handle, once it
gets destroyed. Close the file handle in the class destructor
Client.__del__().
Fixes: 6ea3dfe1e0732 ("selftests: add TPM 2.0 tests")
Cc: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
| -rw-r--r-- | tools/testing/selftests/tpm2/tpm2.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tools/testing/selftests/tpm2/tpm2.py b/tools/testing/selftests/tpm2/tpm2.py index 057a4f49c79d..c7363c6764fc 100644 --- a/tools/testing/selftests/tpm2/tpm2.py +++ b/tools/testing/selftests/tpm2/tpm2.py @@ -371,6 +371,10 @@ class Client: fcntl.fcntl(self.tpm, fcntl.F_SETFL, flags) self.tpm_poll = select.poll() + def __del__(self): + if self.tpm: + self.tpm.close() + def close(self): self.tpm.close() |