diff options
| author | Ahmad Khalifa <ahmad@khalifa.ws> | 2023-09-18 20:47:22 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2023-09-18 20:52:18 +0200 |
| commit | 2dd1d862817b850787f4755c05d55e5aeb76dd08 (patch) | |
| tree | 92b4a676fc19f7a7aeec436fc391a347b723999e | |
| parent | Linux 6.6-rc1 (diff) | |
| download | linux-2dd1d862817b850787f4755c05d55e5aeb76dd08.tar.xz linux-2dd1d862817b850787f4755c05d55e5aeb76dd08.zip | |
hwmon: (nct6775) Fix non-existent ALARM warning
Skip non-existent ALARM attribute to avoid a shift-out-of-bounds
dmesg warning.
Reported-by: Doug Smythies <dsmythies@telus.net>
Closes: https://lore.kernel.org/linux-hwmon/ZQVzdlHgWdFhOVyQ@debian.me/T/#mc69b690660eb50734a6b07506d74a119e0266f1b
Fixes: b7f1f7b2523a ("hwmon: (nct6775) Additional TEMP registers for nct6799")
Signed-off-by: Ahmad Khalifa <ahmad@khalifa.ws>
Link: https://lore.kernel.org/r/20230918184722.2033225-1-ahmad@khalifa.ws
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/nct6775-core.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index 02a71244fc3b..b5b81bd83bb1 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -1910,6 +1910,10 @@ static umode_t nct6775_in_is_visible(struct kobject *kobj, struct device *dev = kobj_to_dev(kobj); struct nct6775_data *data = dev_get_drvdata(dev); int in = index / 5; /* voltage index */ + int nr = index % 5; /* attribute index */ + + if (nr == 1 && data->ALARM_BITS[in] == -1) + return 0; if (!(data->have_in & BIT(in))) return 0; |