diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-02-01 14:28:27 +0100 |
|---|---|---|
| committer | Matthew Garrett <matthew.garrett@nebula.com> | 2013-02-27 14:30:43 +0100 |
| commit | 34cf1df34aba1a6274deeef92ad6d02d5f52dab0 (patch) | |
| tree | ea9f8a7db5b603671e245e5e5b53334ef4e09afc | |
| parent | hp-wmi: Add support for SMBus hotkeys (diff) | |
| download | linux-34cf1df34aba1a6274deeef92ad6d02d5f52dab0.tar.xz linux-34cf1df34aba1a6274deeef92ad6d02d5f52dab0.zip | |
sony-laptop: leak in error handling sony_nc_lid_resume_setup()
We need to decrement "i" first because the current "i" was not allocated
succesfully. Also we should go free the way down to zero to avoid a
leak.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
| -rw-r--r-- | drivers/platform/x86/sony-laptop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c index 438c7fa999f8..9557414954fa 100644 --- a/drivers/platform/x86/sony-laptop.c +++ b/drivers/platform/x86/sony-laptop.c @@ -2351,7 +2351,7 @@ static int sony_nc_lid_resume_setup(struct platform_device *pd) return 0; liderror: - for (; i > 0; i--) + for (i--; i >= 0; i--) device_remove_file(&pd->dev, &lid_ctl->attrs[i]); kfree(lid_ctl); |