diff options
| author | Danny Kaehn <kaehndan@gmail.com> | 2023-02-10 18:00:44 +0100 |
|---|---|---|
| committer | Benjamin Tissoires <benjamin.tissoires@redhat.com> | 2023-02-23 16:45:38 +0100 |
| commit | 37f5b858a66543b2b67c0288280af623985abc29 (patch) | |
| tree | 841646ab8c144b01719f29d616d5f5c81da1066d | |
| parent | selftest: hid: fix hid_bpf not set in config (diff) | |
| download | linux-37f5b858a66543b2b67c0288280af623985abc29.tar.xz linux-37f5b858a66543b2b67c0288280af623985abc29.zip | |
HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded
The CP2112 generates interrupts from a polling routine on a thread,
and can only support threaded interrupts. This patch configures the
gpiochip irq chip with this flag, disallowing consumers to request
a hard IRQ from this driver, which resulted in a segfault previously.
Signed-off-by: Danny Kaehn <kaehndan@gmail.com>
Link: https://lore.kernel.org/r/20230210170044.11835-1-kaehndan@gmail.com
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
| -rw-r--r-- | drivers/hid/hid-cp2112.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 1e16b0fa310d..27cadadda7c9 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -1354,6 +1354,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) girq->parents = NULL; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; + girq->threaded = true; ret = gpiochip_add_data(&dev->gc, dev); if (ret < 0) { |