diff options
| author | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2023-09-19 09:12:50 +0200 |
|---|---|---|
| committer | Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> | 2023-11-21 10:09:33 +0100 |
| commit | 38360bf96d816e175bc602c4ee76953cd303b71d (patch) | |
| tree | d911d1f7b4622faa1d7076861e3fd265b5f21a8c | |
| parent | drm/sprd: Convert to platform remove callback returning void (diff) | |
| download | linux-38360bf96d816e175bc602c4ee76953cd303b71d.tar.xz linux-38360bf96d816e175bc602c4ee76953cd303b71d.zip | |
drm/tilcdc: Fix irq free on unload
The driver only frees the reserved irq if priv->irq_enabled is set to
true. However, the driver mistakenly sets priv->irq_enabled to false,
instead of true, in tilcdc_irq_install(), and thus the driver never
frees the irq, causing issues on loading the driver a second time.
Fixes: b6366814fa77 ("drm/tilcdc: Convert to Linux IRQ interfaces")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Aradhya Bhatia <a-bhatia1@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230919-lcdc-v1-1-ba60da7421e1@ideasonboard.com
| -rw-r--r-- | drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 8ebd7134ee21..2f6eaac7f659 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -138,7 +138,7 @@ static int tilcdc_irq_install(struct drm_device *dev, unsigned int irq) if (ret) return ret; - priv->irq_enabled = false; + priv->irq_enabled = true; return 0; } |