diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2024-01-07 11:02:04 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-01-22 12:29:33 +0100 |
| commit | 3aa58cb51318e329d203857f7a191678e60bb714 (patch) | |
| tree | 62ff1c09eec349caed59ed15a0594bc5dcd88951 | |
| parent | dmaengine: fsl-qdma: Fix a memory leak related to the status queue DMA (diff) | |
| download | linux-3aa58cb51318e329d203857f7a191678e60bb714.tar.xz linux-3aa58cb51318e329d203857f7a191678e60bb714.zip | |
dmaengine: fsl-qdma: Fix a memory leak related to the queue command DMA
This dma_alloc_coherent() is undone neither in the remove function, nor in
the error handling path of fsl_qdma_probe().
Switch to the managed version to fix both issues.
Fixes: b092529e0aa0 ("dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/7f66aa14f59d32b13672dde28602b47deb294e1f.1704621515.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/fsl-qdma.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index 28c4e86bbcd2..9b141369bea5 100644 --- a/drivers/dma/fsl-qdma.c +++ b/drivers/dma/fsl-qdma.c @@ -514,11 +514,11 @@ static struct fsl_qdma_queue queue_temp = queue_head + i + (j * queue_num); queue_temp->cq = - dma_alloc_coherent(&pdev->dev, - sizeof(struct fsl_qdma_format) * - queue_size[i], - &queue_temp->bus_addr, - GFP_KERNEL); + dmam_alloc_coherent(&pdev->dev, + sizeof(struct fsl_qdma_format) * + queue_size[i], + &queue_temp->bus_addr, + GFP_KERNEL); if (!queue_temp->cq) return NULL; queue_temp->block_base = fsl_qdma->block_base + |