diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-09-25 11:55:25 +0200 |
|---|---|---|
| committer | Nishanth Menon <nm@ti.com> | 2023-10-02 16:11:45 +0200 |
| commit | 3af4ec7c7dd39a2c4618f6536b2e7b73a19be169 (patch) | |
| tree | 6043f8cea9a6212f965493eec860c4c5215b4e3a | |
| parent | soc/ti: k3-ringacc: Convert to platform remove callback returning void (diff) | |
| download | linux-3af4ec7c7dd39a2c4618f6536b2e7b73a19be169.tar.xz linux-3af4ec7c7dd39a2c4618f6536b2e7b73a19be169.zip | |
soc/ti: knav_dma: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> # qcom
Link: https://lore.kernel.org/r/20230925095532.1984344-35-u.kleine-koenig@pengutronix.de
Signed-off-by: Nishanth Menon <nm@ti.com>
| -rw-r--r-- | drivers/soc/ti/knav_dma.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 0fbc37cd5123..6023006685fc 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -773,7 +773,7 @@ err_pm_disable: return ret; } -static int knav_dma_remove(struct platform_device *pdev) +static void knav_dma_remove(struct platform_device *pdev) { struct knav_dma_device *dma; @@ -784,8 +784,6 @@ static int knav_dma_remove(struct platform_device *pdev) pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static struct of_device_id of_match[] = { @@ -797,7 +795,7 @@ MODULE_DEVICE_TABLE(of, of_match); static struct platform_driver knav_dma_driver = { .probe = knav_dma_probe, - .remove = knav_dma_remove, + .remove_new = knav_dma_remove, .driver = { .name = "keystone-navigator-dma", .of_match_table = of_match, |